You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "yoavcloud (via GitHub)" <gi...@apache.org> on 2025/01/20 09:54:28 UTC
[PR] Parse Snowflake COPY INTO [datafusion-sqlparser-rs]
yoavcloud opened a new pull request, #1669:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1669
This PR adds support for parsing Snowflake's `COPY INTO <location>`, makes a distinction between `COPY INTO <table>`, and reuses much of its logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Parse Snowflake COPY INTO [datafusion-sqlparser-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #1669:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1669#issuecomment-2643650028
🚀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Parse Snowflake COPY INTO [datafusion-sqlparser-rs]
Posted by "iffyio (via GitHub)" <gi...@apache.org>.
iffyio merged PR #1669:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1669
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Parse Snowflake COPY INTO [datafusion-sqlparser-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #1669:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1669#discussion_r1923339360
##########
src/ast/spans.rs:
##########
@@ -342,6 +343,15 @@ impl Spanned for Statement {
copy_options: _,
validation_mode: _,
} => Span::empty(),
+ Statement::CopyIntoSnowflakeLocation {
Review Comment:
`CopyIntoSnowflake` shares `into`, `partition`, `file_format`, `copy_options` fields -- did you consider keeping `Statement::CopyIntoSnowflake` and add an enum like `target` to distinguish the two forms?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Parse Snowflake COPY INTO [datafusion-sqlparser-rs]
Posted by "yoavcloud (via GitHub)" <gi...@apache.org>.
yoavcloud commented on PR #1669:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1669#issuecomment-2636487913
@alamb reminder to look at the updated PR based on your suggestion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org