You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2018/09/19 04:47:01 UTC
Review Request 68755: Removed unnecessary failure handling in agent
HTTP API handlers.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68755/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
Bugs: MESOS-9228
https://issues.apache.org/jira/browse/MESOS-9228
Repository: mesos
Description
-------
The current agent HTTP API handlers either unnecessarily handle failures
on always-ready futures, or return "500 Internal Server Error"
unnecessarily. This patch removes those unnecessarily code.
Diffs
-----
src/slave/http.cpp f8199af50cf0b43bbbb8c29afe751fcd8949d7e8
Diff: https://reviews.apache.org/r/68755/diff/1/
Testing
-------
make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 68755: Removed unnecessary failure handling in
agent HTTP API handlers.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68755/#review208758
-----------------------------------------------------------
Ship it!
Ship It!
- Jan Schlicht
On Sept. 19, 2018, 6:47 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68755/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2018, 6:47 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-9228
> https://issues.apache.org/jira/browse/MESOS-9228
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The current agent HTTP API handlers either unnecessarily handle failures
> on always-ready futures, or return "500 Internal Server Error"
> unnecessarily. This patch removes those unnecessarily code.
>
>
> Diffs
> -----
>
> src/slave/http.cpp f8199af50cf0b43bbbb8c29afe751fcd8949d7e8
>
>
> Diff: https://reviews.apache.org/r/68755/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 68755: Removed unnecessary failure handling in
agent HTTP API handlers.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68755/#review208755
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Bannier
On Sept. 19, 2018, 6:47 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68755/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2018, 6:47 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-9228
> https://issues.apache.org/jira/browse/MESOS-9228
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The current agent HTTP API handlers either unnecessarily handle failures
> on always-ready futures, or return "500 Internal Server Error"
> unnecessarily. This patch removes those unnecessarily code.
>
>
> Diffs
> -----
>
> src/slave/http.cpp f8199af50cf0b43bbbb8c29afe751fcd8949d7e8
>
>
> Diff: https://reviews.apache.org/r/68755/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 68755: Removed unnecessary failure handling in
agent HTTP API handlers.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68755/#review208747
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On Sept. 18, 2018, 9:47 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68755/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2018, 9:47 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-9228
> https://issues.apache.org/jira/browse/MESOS-9228
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The current agent HTTP API handlers either unnecessarily handle failures
> on always-ready futures, or return "500 Internal Server Error"
> unnecessarily. This patch removes those unnecessarily code.
>
>
> Diffs
> -----
>
> src/slave/http.cpp f8199af50cf0b43bbbb8c29afe751fcd8949d7e8
>
>
> Diff: https://reviews.apache.org/r/68755/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>