You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/09 12:13:42 UTC
[GitHub] [incubator-superset] Nj-kol opened a new pull request #10269: fix: Fixed bug for issue #9967
Nj-kol opened a new pull request #10269:
URL: https://github.com/apache/incubator-superset/pull/10269
### SUMMARY
The issue was first observed in #7270
However, in the subsequent releases, the variable time_grain_functions was renamed to _time_grain_expressions. The implementation was also left out for hive. So time functions were not renamed which were specific to Hive. This was causing the group by functions in the Charts to malfunction
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
**Before**
**After**
## TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue: closes #9967
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] Nj-kol commented on pull request #10269: fix: Fixed bug for issue #9967
Posted by GitBox <gi...@apache.org>.
Nj-kol commented on pull request #10269:
URL: https://github.com/apache/incubator-superset/pull/10269#issuecomment-656122281
> Great, thanks for your perseverence @Nj-kol ! π
@villebro A big thanks to you and the community for your patience :)
Hope to contribute a lot more in the coming days!
One question - How do I add my company name to the list of superset users?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on pull request #10269: fix: Fixed bug for issue #9967
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #10269:
URL: https://github.com/apache/incubator-superset/pull/10269#issuecomment-656212806
@nielsenrechia Yeah, gonna be in `0.37.0` π
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] Nj-kol commented on pull request #10269: fix: Fixed bug for issue #9967
Posted by GitBox <gi...@apache.org>.
Nj-kol commented on pull request #10269:
URL: https://github.com/apache/incubator-superset/pull/10269#issuecomment-656103792
@villebro Created this new PR. Could you please review this? Also not sure why the CI is still failing, I installed the git-hook : https://github.com/apache/incubator-superset/blob/master/CONTRIBUTING.md#git-hooks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nielsenrechia commented on pull request #10269: fix: Fixed bug for issue #9967
Posted by GitBox <gi...@apache.org>.
nielsenrechia commented on pull request #10269:
URL: https://github.com/apache/incubator-superset/pull/10269#issuecomment-656208275
Hello Guys, thanks for the solution. Just to confirm, it will be included on the version 0.37, right?
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on pull request #10269: fix: Fixed bug for issue #9967
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #10269:
URL: https://github.com/apache/incubator-superset/pull/10269#issuecomment-656120013
Great, thanks for your perseverence @Nj-kol ! π
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #10269: fix: Fixed bug for issue #9967
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10269:
URL: https://github.com/apache/incubator-superset/pull/10269#issuecomment-656111114
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10269?src=pr&el=h1) Report
> Merging [#10269](https://codecov.io/gh/apache/incubator-superset/pull/10269?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6224edd42d5a99ccc7922985fa44bd8c6c43c2db&el=desc) will **decrease** coverage by `10.94%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10269?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10269 +/- ##
===========================================
- Coverage 70.26% 59.31% -10.95%
===========================================
Files 598 404 -194
Lines 32011 13148 -18863
Branches 3239 3239
===========================================
- Hits 22491 7799 -14692
+ Misses 9417 5168 -4249
- Partials 103 181 +78
```
| Flag | Coverage Ξ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.31% <ΓΈ> (ΓΈ)` | |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10269?src=pr&el=tree) | Coverage Ξ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10269/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10269/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10269/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10269/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10269/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10269/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/10269/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10269/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/10269/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/10269/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [330 more](https://codecov.io/gh/apache/incubator-superset/pull/10269/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10269?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10269?src=pr&el=footer). Last update [6224edd...f11c30c](https://codecov.io/gh/apache/incubator-superset/pull/10269?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro merged pull request #10269: fix: Fixed bug for issue #9967
Posted by GitBox <gi...@apache.org>.
villebro merged pull request #10269:
URL: https://github.com/apache/incubator-superset/pull/10269
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on pull request #10269: fix: Fixed bug for issue #9967
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #10269:
URL: https://github.com/apache/incubator-superset/pull/10269#issuecomment-656123261
Oh, that's easy, just open a single line PR on `README.md` π
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on pull request #10269: fix: Fixed bug for issue #9967
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #10269:
URL: https://github.com/apache/incubator-superset/pull/10269#issuecomment-656105492
Can you try to undo the change to `setup.cfg` and do a commit like this `git commit -m "lint" --no-verify` and then push that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] Nj-kol commented on pull request #10269: fix: Fixed bug for issue #9967
Posted by GitBox <gi...@apache.org>.
Nj-kol commented on pull request #10269:
URL: https://github.com/apache/incubator-superset/pull/10269#issuecomment-656118992
> Can you try to undo the change to `setup.cfg` and do a commit like this `git commit -m "lint" --no-verify` and then push that.
Worked like a charm! Thanks. I hope this should do the trick, request you to review once
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org