You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/08/23 13:32:30 UTC

[GitHub] [arrow-datafusion] alamb opened a new pull request #929: EXPLAIN ANALYZE should run all Optimizer passes

alamb opened a new pull request #929:
URL: https://github.com/apache/arrow-datafusion/pull/929


   # Which issue does this PR close?
   Fixes https://github.com/apache/arrow-datafusion/issues/917 found by @Dandandan 
   
   
   # Rationale for this change
   1. `EXPLAIN ANALYZE` should run the same plan as normal execution
   
   # What changes are included in this PR?
   1. Fix bug
   2. Add test
   3. Add `assert_contains!` macro in sql.rs (from IOx) to make the testing less repetitious
   
   
   # Are there any user-facing changes?
   Bug is fixed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb merged pull request #929: EXPLAIN ANALYZE should run all Optimizer passes

Posted by GitBox <gi...@apache.org>.
alamb merged pull request #929:
URL: https://github.com/apache/arrow-datafusion/pull/929


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on a change in pull request #929: EXPLAIN ANALYZE should run all Optimizer passes

Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #929:
URL: https://github.com/apache/arrow-datafusion/pull/929#discussion_r693976120



##########
File path: datafusion/src/optimizer/utils.rs
##########
@@ -195,11 +195,21 @@ pub fn from_plan(
             schema: schema.clone(),
             alias: alias.clone(),
         }),
+        LogicalPlan::Analyze {
+            verbose, schema, ..
+        } => {
+            assert!(expr.is_empty());

Review comment:
       Here is the actual bug fix: the code that builds up LogicalPlans from optimized inputs ignored the inputs for Analyze. I have a follow on PR to try and make this kind of thing harder to introduce in the future:  https://github.com/apache/arrow-datafusion/pull/930 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org