[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8100: SQL support for t-digest based sketch aggregators

[GitBox <gi...@apache.org>]

jon-wei commented on a change in pull request #8100: SQL support for t-digest based sketch aggregators
URL: https://github.com/apache/incubator-druid/pull/8100#discussion_r308486747
 
 

 ##########
 File path: docs/content/development/extensions-contrib/tdigestsketch-quantiles.md
 ##########
 @@ -70,49 +68,22 @@ Example:
 }
 ```
 
-|property|description|required?|
-|--------|-----------|---------|
-|type|This String should always be "buildTDigestSketch"|yes|
-|name|A String for the output (result) name of the calculation.|yes|
-|fieldName|A String for the name of the input field containing raw numeric values.|yes|
-|compression|Parameter that determines the accuracy and size of the sketch. Higher compression means higher accuracy but more space to store sketches.|no, defaults to 100|
-
-
-The result of the aggregation is a T-Digest sketch that is built by merging pre-built T-Digest sketches.
-
 ```json
 {
-  "type" : "mergeTDigestSketch",
-  "name" : <output_name>,
-  "fieldName" : <metric_name>,
-  "compression": <parameter that controls size and accuracy>
- }
+	"type": "buildTDigestSketch",
+	"name": "combined_sketch",
+	"fieldName": "ingested_sketch",
 
 Review comment:
   Suggest changing `"ingested_sketch"` here to `<input-column>`, since the aggregator can accept raw values or pre-generated sketches

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org