You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Boni Gopalan (JIRA)" <ji...@apache.org> on 2008/09/25 08:11:44 UTC

[jira] Updated: (JCR-1762) Improvement to MultiValueCollectionConverterImpl to Map collections with element class Object.class

     [ https://issues.apache.org/jira/browse/JCR-1762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Boni Gopalan updated JCR-1762:
------------------------------

    Attachment: JCR-1762-patch.zip

Files Changed :
============
src/main/java/org/apache/jackrabbit/ocm/manager/collectionconverter/impl/MultiValueCollectionConverterImpl.java
src/main/java/org/apache/jackrabbit/ocm/mapper/impl/AbstractMapperImpl.java
src/main/java/org/apache/jackrabbit/ocm/mapper/impl/annotation/AnnotationDescriptorReader.java

Test Cases Added  (Some modified):
============
Path
src/test/java/org/apache/jackrabbit/ocm/AnnotationTestBase.java
src/test/test-config/jcrmapping-atomic.xml
jsrc/test/ava/org/apache/jackrabbit/ocm/manager/collectionconverter/AnnotationMultiValueWithObjectCollectionConverterImplTest.java
src/test/java/org/apache/jackrabbit/ocm/manager/collectionconverter/DigesterMultiValueWithObjectCollectionConverterImplTest.java
src/test/java/org/apache/jackrabbit/ocm/testmodel/MultiValueWithObjectCollection.java




> Improvement to MultiValueCollectionConverterImpl to Map collections with element class Object.class
> ---------------------------------------------------------------------------------------------------
>
>                 Key: JCR-1762
>                 URL: https://issues.apache.org/jira/browse/JCR-1762
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-ocm
>    Affects Versions: 1.5
>         Environment: Java 5 and Up
>            Reporter: Boni Gopalan
>            Priority: Minor
>         Attachments: JCR-1762-patch.zip
>
>   Original Estimate: 3h
>  Remaining Estimate: 3h
>
> Currently MultiValueCollectionConverterImpl  does not support elements of type Object.class.  The type of the contained class has to be specified either through the mapping file or through the Bean annotation.  Even with that flexibility Object.class is specifically excluded (For good reasons.).  
> My view is that by definition MultiValueCollectionConverterImpl   should make a best effort to convert and that best effort should include using Undefined UndefinedTypeConverterImpl to convert an object when all the other conversion strategies run out.  To this resolve I have patched the OCM source.  I have test cases also.  I will upload the patch files right after.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.