You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/17 04:35:39 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request #27601:
[SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
HyukjinKwon opened a new pull request #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601
### What changes were proposed in this pull request?
This PR proposes to port Scala's bug fix https://github.com/scala/scala/pull/7693 (Scala 2.13) to fix https://github.com/scala/bug/issues/10495 issue.
In short, it is possible for different product instances having the same children to have the same hash. See:
```scala
scala> spark.range(1).selectExpr("id - 1").queryExecution.analyzed.semanticHash()
res0: Int = -565572825
scala> spark.range(1).selectExpr("id + 1").queryExecution.analyzed.semanticHash()
res1: Int = -565572825
```
### Why are the changes needed?
It was found during the review of https://github.com/apache/spark/pull/27565; however, I suspect this can potentially be correctness issue.
### Does this PR introduce any user-facing change?
Possibly yes; however, it's not identified yet. See
### How was this patch tested?
Manually tested, and unittest was added.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27601:
[SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#discussion_r380012000
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
##########
@@ -114,7 +114,29 @@ abstract class TreeNode[BaseType <: TreeNode[BaseType]] extends Product {
lazy val containsChild: Set[TreeNode[_]] = children.toSet
- private lazy val _hashCode: Int = scala.util.hashing.MurmurHash3.productHash(this)
+ // Copied from Scala 2.13.1
+ // github.com/scala/scala/blob/v2.13.1/src/library/scala/util/hashing/MurmurHash3.scala#L56-L73
+ // to prevent the issue https://github.com/scala/bug/issues/10495
+ private final def productHash(x: Product, seed: Int, ignorePrefix: Boolean = false): Int = {
+ val arr = x.productArity
+ // Case objects have the hashCode inlined directly into the
+ // synthetic hashCode method, but this method should still give
+ // a correct result if passed a case object.
+ if (arr == 0) {
+ x.productPrefix.hashCode
+ } else {
+ var h = seed
+ if (!ignorePrefix) h = scala.util.hashing.MurmurHash3.mix(h, x.productPrefix.hashCode)
Review comment:
So, only this line is the fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27601:
[SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#discussion_r379986173
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
##########
@@ -114,7 +114,29 @@ abstract class TreeNode[BaseType <: TreeNode[BaseType]] extends Product {
lazy val containsChild: Set[TreeNode[_]] = children.toSet
- private lazy val _hashCode: Int = scala.util.hashing.MurmurHash3.productHash(this)
Review comment:
`scala.util.hashing.MurmurHash3.productHash` calls the same implementations linked above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27601:
[SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-586864332
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27601:
[SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-586878099
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23313/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27601: [SPARK-30847][SQL]
Take productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-586874890
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27601: [SPARK-30847][SQL]
Take productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-586819163
I corrected the description accordingly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27601: [SPARK-30847][SQL] Take
productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-586814664
**[Test build #118527 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118527/testReport)** for PR 27601 at commit [`f5d4871`](https://github.com/apache/spark/commit/f5d4871367d9877061774e69f1766f9c602b1a65).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27601:
[SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-586982806
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118558/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27601: [SPARK-30847][SQL]
Take productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-586982783
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27601: [SPARK-30847][SQL]
Take productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-586819629
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23286/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27601:
[SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#discussion_r379984731
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
##########
@@ -114,7 +114,29 @@ abstract class TreeNode[BaseType <: TreeNode[BaseType]] extends Product {
lazy val containsChild: Set[TreeNode[_]] = children.toSet
- private lazy val _hashCode: Int = scala.util.hashing.MurmurHash3.productHash(this)
Review comment:
so Scala doesn't fix `scala.util.hashing.MurmurHash3.productHash`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27601:
[SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-586819366
**[Test build #118531 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118531/testReport)** for PR 27601 at commit [`eacf7f3`](https://github.com/apache/spark/commit/eacf7f317e1dd74d72a1368d541011815b4c43fe).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27601: [SPARK-30847][SQL] Take
productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-586983328
**[Test build #118580 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118580/testReport)** for PR 27601 at commit [`c94fa84`](https://github.com/apache/spark/commit/c94fa84ab94a3c189ac6beca8e26f87a276f782d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #27601: [SPARK-30847][SQL]
Take productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27601: [SPARK-30847][SQL] Take
productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-586982013
**[Test build #118558 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118558/testReport)** for PR 27601 at commit [`c94fa84`](https://github.com/apache/spark/commit/c94fa84ab94a3c189ac6beca8e26f87a276f782d).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27601:
[SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-587121942
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27601:
[SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-587121952
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118580/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27601: [SPARK-30847][SQL] Take
productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-586864085
**[Test build #118531 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118531/testReport)** for PR 27601 at commit [`eacf7f3`](https://github.com/apache/spark/commit/eacf7f317e1dd74d72a1368d541011815b4c43fe).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27601: [SPARK-30847][SQL]
Take productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-586985189
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27601:
[SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#discussion_r379985963
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
##########
@@ -114,7 +114,29 @@ abstract class TreeNode[BaseType <: TreeNode[BaseType]] extends Product {
lazy val containsChild: Set[TreeNode[_]] = children.toSet
- private lazy val _hashCode: Int = scala.util.hashing.MurmurHash3.productHash(this)
Review comment:
Scala 2.12 didn't fix:
https://github.com/scala/scala/blob/2.12.x/src/library/scala/util/hashing/MurmurHash3.scala#L61-L79
but Scala 2.13 fixed it:
https://github.com/scala/scala/blob/v2.13.1/src/library/scala/util/hashing/MurmurHash3.scala#L56-L73
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27601: [SPARK-30847][SQL]
Take productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-587300412
thanks, merging to master/3.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27601:
[SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-586819629
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23286/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27601: [SPARK-30847][SQL]
Take productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-586865226
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27601: [SPARK-30847][SQL] Take
productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-586864083
**[Test build #118527 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118527/testReport)** for PR 27601 at commit [`f5d4871`](https://github.com/apache/spark/commit/f5d4871367d9877061774e69f1766f9c602b1a65).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27601: [SPARK-30847][SQL]
Take productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-586864347
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118531/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27601:
[SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-586814664
**[Test build #118527 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118527/testReport)** for PR 27601 at commit [`f5d4871`](https://github.com/apache/spark/commit/f5d4871367d9877061774e69f1766f9c602b1a65).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27601: [SPARK-30847][SQL]
Take productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-586982806
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118558/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27601: [SPARK-30847][SQL]
Take productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-586985214
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23334/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27601: [SPARK-30847][SQL]
Take productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-586814823
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23283/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27601:
[SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-586864347
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118531/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27601:
[SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-586865226
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27601:
[SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-586874902
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23312/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27601:
[SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#discussion_r380033807
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
##########
@@ -114,7 +114,29 @@ abstract class TreeNode[BaseType <: TreeNode[BaseType]] extends Product {
lazy val containsChild: Set[TreeNode[_]] = children.toSet
- private lazy val _hashCode: Int = scala.util.hashing.MurmurHash3.productHash(this)
Review comment:
can we add a comment? When we drop scala 2.12 and move to scala 2.13, we can remove this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27601: [SPARK-30847][SQL]
Take productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-586874902
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23312/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27601:
[SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-586983328
**[Test build #118580 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118580/testReport)** for PR 27601 at commit [`c94fa84`](https://github.com/apache/spark/commit/c94fa84ab94a3c189ac6beca8e26f87a276f782d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27601: [SPARK-30847][SQL] Take
productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-586819366
**[Test build #118531 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118531/testReport)** for PR 27601 at commit [`eacf7f3`](https://github.com/apache/spark/commit/eacf7f317e1dd74d72a1368d541011815b4c43fe).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27601:
[SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-586985189
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27601: [SPARK-30847][SQL]
Take productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-587121942
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27601: [SPARK-30847][SQL]
Take productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-586819623
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27601:
[SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-586814817
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27601: [SPARK-30847][SQL] Take
productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-586877543
**[Test build #118558 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118558/testReport)** for PR 27601 at commit [`c94fa84`](https://github.com/apache/spark/commit/c94fa84ab94a3c189ac6beca8e26f87a276f782d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27601: [SPARK-30847][SQL]
Take productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-586874646
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27601:
[SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-586819623
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27601:
[SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-586985214
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23334/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27601: [SPARK-30847][SQL]
Take productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-587121952
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118580/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27601:
[SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-586877543
**[Test build #118558 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118558/testReport)** for PR 27601 at commit [`c94fa84`](https://github.com/apache/spark/commit/c94fa84ab94a3c189ac6beca8e26f87a276f782d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27601: [SPARK-30847][SQL]
Take productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-586864332
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27601:
[SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-586878093
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27601: [SPARK-30847][SQL]
Take productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-586865238
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118527/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27601: [SPARK-30847][SQL]
Take productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-586878093
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27601: [SPARK-30847][SQL]
Take productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-586878099
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23313/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27601:
[SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#discussion_r380041612
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
##########
@@ -114,7 +114,29 @@ abstract class TreeNode[BaseType <: TreeNode[BaseType]] extends Product {
lazy val containsChild: Set[TreeNode[_]] = children.toSet
- private lazy val _hashCode: Int = scala.util.hashing.MurmurHash3.productHash(this)
Review comment:
Yup.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27601:
[SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-586865238
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118527/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27601: [SPARK-30847][SQL]
Take productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-586813892
cc @JoshRosen, @cloud-fan, @mengxr, @WeichenXu123
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27601: [SPARK-30847][SQL] Take
productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-587121405
**[Test build #118580 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118580/testReport)** for PR 27601 at commit [`c94fa84`](https://github.com/apache/spark/commit/c94fa84ab94a3c189ac6beca8e26f87a276f782d).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27601: [SPARK-30847][SQL]
Take productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-586982792
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27601:
[SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-586814823
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23283/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27601: [SPARK-30847][SQL]
Take productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-586816348
It's good to avoid hash collision, but I don't think it's a correctness issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27601:
[SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-586982792
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27601: [SPARK-30847][SQL]
Take productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-586814817
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27601:
[SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash
URL: https://github.com/apache/spark/pull/27601#issuecomment-586874890
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org