You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/04/07 10:16:33 UTC

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6003: esp32c3: Simplify irq dispatch logic

pkarashchenko commented on code in PR #6003:
URL: https://github.com/apache/incubator-nuttx/pull/6003#discussion_r844965387


##########
arch/risc-v/src/esp32c3/esp32c3_irq.c:
##########
@@ -355,7 +355,7 @@ void esp32c3_free_cpuint(uint8_t periphid)
 IRAM_ATTR uintptr_t *esp32c3_dispatch_irq(uintptr_t mcause, uintptr_t *regs)
 {
   int irq;
-  uintptr_t *mepc = regs;
+  uint8_t cpuint = mcause & RISCV_IRQ_MASK;

Review Comment:
   is `uint8_t` a sufficient holder for result? `RISCV_IRQ_MASK` seems to be a `uintptr_t` size.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org