You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by "prb17 (via GitHub)" <gi...@apache.org> on 2023/05/28 13:40:42 UTC
[GitHub] [activemq-artemis] prb17 opened a new pull request, #4489: Fix for large, compressed, ObjectMessage types, getting UTFDataFormat…
prb17 opened a new pull request, #4489:
URL: https://github.com/apache/activemq-artemis/pull/4489
…Exception when deserializing message on client side
When larger object types (greater than 1024 bytes), and compressed, are de-serialized, UTFDataFormatException occurs on the client side.
The InputStream object, `ois`, just needs to keep reading into the `buf` byte[] until all the bytes are ready. Currently, if the ByteSequence object, `contents`, is larger that 1024 bytes, the while loop will only ready a byte at a time instead of the intended 'as many bytes as can fit into `buf`' paradigm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic merged pull request #4489: ARTEMIS-4309 Fix for large, compressed, ObjectMessage types, getting UTFDataFormat…
Posted by "clebertsuconic (via GitHub)" <gi...@apache.org>.
clebertsuconic merged PR #4489:
URL: https://github.com/apache/activemq-artemis/pull/4489
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] prb17 commented on pull request #4489: Fix for large, compressed, ObjectMessage types, getting UTFDataFormat…
Posted by "prb17 (via GitHub)" <gi...@apache.org>.
prb17 commented on PR #4489:
URL: https://github.com/apache/activemq-artemis/pull/4489#issuecomment-1575655512
@tabish121 Understood, I'll come up with some tests.
@jbertram I requested access the Apache's Jira but have not received access yet. This was about 2 weeks ago. What's best in this scenario, should an existing maintainer assign a Jira ticket number or should I get access and do it myself?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #4489: ARTEMIS-4309 Fix for large, compressed, ObjectMessage types, getting UTFDataFormat…
Posted by "clebertsuconic (via GitHub)" <gi...@apache.org>.
clebertsuconic commented on PR #4489:
URL: https://github.com/apache/activemq-artemis/pull/4489#issuecomment-1589189166
@prb17 I'm just confused.. I'm not discussing your changes here.. just trying to understand when the large message was kicked in.. what's setting it on.
you added a text files which is about TEXT * 5 times. I can't find the minLargeMessageSize set anywhere in that test.
I will merge this fix BTW. I'm just trying to understand what set this off on that test. Because I thought it was not supposed to use a large message with the little text is using.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] tabish121 commented on pull request #4489: Fix for large, compressed, ObjectMessage types, getting UTFDataFormat…
Posted by "tabish121 (via GitHub)" <gi...@apache.org>.
tabish121 commented on PR #4489:
URL: https://github.com/apache/activemq-artemis/pull/4489#issuecomment-1570473630
PR lacks any tests that validate the issue and ensure it remains fixed into the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] jbertram commented on pull request #4489: Fix for large, compressed, ObjectMessage types, getting UTFDataFormat…
Posted by "jbertram (via GitHub)" <gi...@apache.org>.
jbertram commented on PR #4489:
URL: https://github.com/apache/activemq-artemis/pull/4489#issuecomment-1583244201
FWIW, the commits should be squashed together and the commit message should follow [this format](https://github.com/apache/activemq-artemis/blob/main/docs/hacking-guide/en/code.md#commitMessageDetails).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gemmellr commented on a diff in pull request #4489: Fix for large, compressed, ObjectMessage types, getting UTFDataFormat…
Posted by "gemmellr (via GitHub)" <gi...@apache.org>.
gemmellr commented on code in PR #4489:
URL: https://github.com/apache/activemq-artemis/pull/4489#discussion_r1224052630
##########
tests/activemq5-unit-tests/src/test/java/org/apache/activemq/command/MessageCompressionTest.java:
##########
@@ -216,13 +216,37 @@ public void testObjectMessageCompression() throws Exception {
assertTrue("expected: compressed Size '" + compressedSize + "' < unCompressedSize '" + unCompressedSize + "'", compressedSize < unCompressedSize);
}
+ public void testLargeObjectMessageCompression() throws Exception {
Review Comment:
Although it certainly matches the surroundings, I dont think this test should be added here. These classes are somewhat extra ones originally ported across from the 5.x test suite, they dont typically have new tests added into them.
The test should instead go in the integration-tests module, perhaps fitting in the existing org.apache.activemq.artemis.tests.integration.openwire.interop.CompressedInteropTest class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] jbertram commented on pull request #4489: Fix for large, compressed, ObjectMessage types, getting UTFDataFormat…
Posted by "jbertram (via GitHub)" <gi...@apache.org>.
jbertram commented on PR #4489:
URL: https://github.com/apache/activemq-artemis/pull/4489#issuecomment-1583221072
I don't recall seeing any request from a user named "prb17" requesting Jira access for ActiveMQ. We try to respond to those requests pretty quickly. Can you try again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] jbertram commented on pull request #4489: Fix for large, compressed, ObjectMessage types, getting UTFDataFormat…
Posted by "jbertram (via GitHub)" <gi...@apache.org>.
jbertram commented on PR #4489:
URL: https://github.com/apache/activemq-artemis/pull/4489#issuecomment-1583223840
Actually ignore my last comment. I think I found your request and approved it. You should be good to go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] jbertram commented on pull request #4489: Fix for large, compressed, ObjectMessage types, getting UTFDataFormat…
Posted by "jbertram (via GitHub)" <gi...@apache.org>.
jbertram commented on PR #4489:
URL: https://github.com/apache/activemq-artemis/pull/4489#issuecomment-1570889536
This also should have an associated Jira.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] prb17 commented on a diff in pull request #4489: ARTEMIS-4309 Fix for large, compressed, ObjectMessage types, getting UTFDataFormat…
Posted by "prb17 (via GitHub)" <gi...@apache.org>.
prb17 commented on code in PR #4489:
URL: https://github.com/apache/activemq-artemis/pull/4489#discussion_r1225572381
##########
tests/activemq5-unit-tests/src/test/java/org/apache/activemq/command/MessageCompressionTest.java:
##########
@@ -216,13 +216,37 @@ public void testObjectMessageCompression() throws Exception {
assertTrue("expected: compressed Size '" + compressedSize + "' < unCompressedSize '" + unCompressedSize + "'", compressedSize < unCompressedSize);
}
+ public void testLargeObjectMessageCompression() throws Exception {
Review Comment:
Understood, I made the change in the file you suggested. Let me know if something doesn't look right and I need to fix something
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] prb17 commented on pull request #4489: ARTEMIS-4309 Fix for large, compressed, ObjectMessage types, getting UTFDataFormat…
Posted by "prb17 (via GitHub)" <gi...@apache.org>.
prb17 commented on PR #4489:
URL: https://github.com/apache/activemq-artemis/pull/4489#issuecomment-1585813365
@jbertram I believe I satisfied the requirements for having an associated Jira, squashed the commits, and followed the Artemis commit message style.
I recognized by pushing first and having to squash later I got myself into a weird state. Just let me know if something else needs to be addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org