You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/07/08 02:15:41 UTC

[GitHub] [beam] lukecwik commented on a change in pull request #12192: [WIP][BEAM-10420] Migrate SDF logic into PerWindowInvoker

lukecwik commented on a change in pull request #12192:
URL: https://github.com/apache/beam/pull/12192#discussion_r451242979



##########
File path: sdks/python/apache_beam/runners/direct/sdf_direct_runner.py
##########
@@ -507,7 +500,6 @@ def initiate_checkpoint():
       if self._max_num_outputs and output_count >= self._max_num_outputs:
         initiate_checkpoint()
 
-    tracker.check_done()

Review comment:
       This is handled within the PerWindowInvoker already.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org