You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@magpie.apache.org by "onlyarnav (via GitHub)" <gi...@apache.org> on 2026/10/02 06:26:17 UTC
[PR] feat(vendor-neutrality): mark contract:chat vendor neutral with Discord adapter [magpie]
onlyarnav opened a new pull request, #1486:
URL: https://github.com/apache/magpie/pull/1486
Part 3 of 3 in the `contract:chat` Discord adapter stack. Depends on #1485.
## Summary
- Regenerates vendor-neutrality scoring via `tools/vendor-neutrality-score`:
- `contract:chat` flips from red (`only 1 backend vendor (Slack); needs 1 more`) to green (`2 backend vendors: Discord, Slack`).
- Overall vendor neutrality score advances to **11/12 capability contracts (92%)**.
- Synchronizes `docs/vendor-neutrality.md` generated tables and score overview.
- Adds regression unit test in `tools/vendor-neutrality-score/tests/test_vendor_neutrality_score.py` verifying multi-vendor evaluation for `contract:chat`.
## Type of change
- [x] Documentation (`docs/`, `README.md`, `CONTRIBUTING.md`)
- [x] CI / dev loop (`prek`, workflows, validators)
## Test plan
- [x] `uv run vendor-neutrality-score` passes and yields 11/12 contracts green with `contract:chat` neutral.
- [x] `uv run pytest tools/vendor-neutrality-score/tests/test_vendor_neutrality_score.py -k "test_chat_contract_is_green_with_slack_and_discord"` passes.
- [x] `ruff check` and `ruff format` pass on `tools/vendor-neutrality-score`.
- [x] `docs/vendor-neutrality.md` generated block matches scorer output.
## RFC-AI-0004 compliance
- [x] **Vendor neutrality** — falsifiable score updated deterministically with zero hand-edits in the generated block.
## Linked issues
Closes #1421
🤖 Generated with Antigravity
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(vendor-neutrality): mark contract:chat vendor neutral with Discord adapter [magpie]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #1486:
URL: https://github.com/apache/magpie/pull/1486#issuecomment-5974661296
Folded into #1485: I fast-forwarded `docs/chat-discord-integration` to this branch's head (`d0c0a8e`), so the scorer test now ships as part of #1485 and the stack is #1484 → #1485. GitHub marks this PR merged because its commit reached the base branch — nothing was lost, and nothing landed on `main`.
The inline note from my review here (assert against the live tree via `load_tools(find_repo_root())` instead of synthetic `ToolMeta`s) now applies to #1485 — please address it there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(vendor-neutrality): mark contract:chat vendor neutral with Discord adapter [magpie]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #1486:
URL: https://github.com/apache/magpie/pull/1486#discussion_r4175400690
##########
tools/vendor-neutrality-score/tests/test_vendor_neutrality_score.py:
##########
@@ -52,6 +52,18 @@ def test_vendor_backed_needs_two_distinct_vendors() -> None:
assert r.vendors == ["Atlassian", "GitHub"]
+def test_chat_contract_is_green_with_slack_and_discord() -> None:
Review Comment:
**minor** — This builds synthetic tools and never reads the repo, so it passes even if `tools/chat-discord/` doesn't exist or declares the wrong Kind/Vendor. To make it a real regression guard, assert against the live tree: load `vns.load_tools(vns.find_repo_root())`, check `chat-discord` is present with vendor `Discord` under `contract:chat`, and that the `contract:chat` result is green. Otherwise it duplicates `test_vendor_backed_needs_two_distinct_vendors` and can be dropped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(vendor-neutrality): mark contract:chat vendor neutral with Discord adapter [magpie]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #1486:
URL: https://github.com/apache/magpie/pull/1486
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org