You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/11/13 12:16:53 UTC
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request, #1416: boot/mcuboot: Bump up version to e4fba687d98bf44a71a7f37f1ef4637a662791c3
xiaoxiang781216 opened a new pull request, #1416:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1416
## Summary
```
Fix Error: mcuboot/boot/bootutil/src/bootutil_public.c:159:1: error: unused function 'boot_swap_size_off' [-Werror,-Wunused-function] boot_swap_size_off(const struct flash_area *fap)
```
## Impact
mcuboot
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] gustavonihei commented on a diff in pull request #1416: boot/mcuboot: Bump up version to 36bac4f6a54a3b76266444d8c6c177b8b0483a05
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on code in PR #1416:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1416#discussion_r1021696159
##########
boot/mcuboot/Kconfig:
##########
@@ -14,7 +14,7 @@ if BOOT_MCUBOOT
config MCUBOOT_VERSION
string "MCUboot version"
- default "bb927ac014787992f2d8b42c7bd5d05eb4c17e05"
+ default "e4fba687d98bf44a71a7f37f1ef4637a662791c3"
Review Comment:
@xiaoxiang781216 it seems you’ve missed to push the commit hash change to 36bac4f6a54a3b76266444d8c6c177b8b0483a05
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1416: boot/mcuboot: Bump up version to e4fba687d98bf44a71a7f37f1ef4637a662791c3
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #1416:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1416#issuecomment-1312744844
The build error is fixed here: https://github.com/mcu-tools/mcuboot/pull/1514
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko merged pull request #1416: boot/mcuboot: Bump up version to 36bac4f6a54a3b76266444d8c6c177b8b0483a05
Posted by GitBox <gi...@apache.org>.
pkarashchenko merged PR #1416:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1416
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1416: boot/mcuboot: Bump up version to 36bac4f6a54a3b76266444d8c6c177b8b0483a05
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #1416:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1416#discussion_r1021887919
##########
boot/mcuboot/Kconfig:
##########
@@ -14,7 +14,7 @@ if BOOT_MCUBOOT
config MCUBOOT_VERSION
string "MCUboot version"
- default "bb927ac014787992f2d8b42c7bd5d05eb4c17e05"
+ default "e4fba687d98bf44a71a7f37f1ef4637a662791c3"
Review Comment:
Yes, you are right, fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org