You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by viirya <gi...@git.apache.org> on 2015/04/13 09:41:59 UTC
[GitHub] spark pull request: [SPARK-6877][SQL] Add code generation support ...
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/5487
[SPARK-6877][SQL] Add code generation support for Min
Currently `min` is not supported in code generation. This pr adds the support for it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/viirya/spark-1 add_min_codegen
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/5487.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5487
----
commit 0ddec238a5b993d09e7da6bb663b1b34d4f44f4c
Author: Liang-Chi Hsieh <vi...@gmail.com>
Date: 2015-04-13T07:37:10Z
Add code generation support for Min.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6877][SQL] Add code generation support ...
Posted by marmbrus <gi...@git.apache.org>.
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/5487#issuecomment-92552525
Thanks, merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6877][SQL] Add code generation support ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5487#issuecomment-92291606
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30153/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6877][SQL] Add code generation support ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/5487
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6877][SQL] Add code generation support ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5487#issuecomment-92254336
[Test build #30153 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30153/consoleFull) for PR 5487 at commit [`0ddec23`](https://github.com/apache/spark/commit/0ddec238a5b993d09e7da6bb663b1b34d4f44f4c).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6877][SQL] Add code generation support ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5487#issuecomment-92291583
[Test build #30153 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30153/consoleFull) for PR 5487 at commit [`0ddec23`](https://github.com/apache/spark/commit/0ddec238a5b993d09e7da6bb663b1b34d4f44f4c).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class StringIndexer extends Estimator[StringIndexerModel] with StringIndexerBase `
* `class VectorAssembler extends Transformer with HasInputCols with HasOutputCol `
* `class VectorIndexer extends Estimator[VectorIndexerModel] with VectorIndexerParams `
* `case class MinOf(left: Expression, right: Expression) extends Expression `
* This patch does not change any dependencies.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org