[GitHub] [spark] fqaiser94 commented on a change in pull request #28631: [MINOR][SQL] Replace struct's class name with CreateStruct

[GitBox <gi...@apache.org>]

fqaiser94 commented on a change in pull request #28631:
URL: https://github.com/apache/spark/pull/28631#discussion_r429656949



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
##########
@@ -325,7 +325,7 @@ object CreateStruct extends FunctionBuilder {
    */
   val registryEntry: (String, (ExpressionInfo, FunctionBuilder)) = {
     val info: ExpressionInfo = new ExpressionInfo(
-      "org.apache.spark.sql.catalyst.expressions.NamedStruct",
+      getClass.getCanonicalName.stripSuffix("$"),

Review comment:
       thank you for fixing this. I remember a while back I wasted a few hours trying to find this mythical       `NamedStruct` class/object without success. 

##########
File path: sql/core/src/test/resources/sql-functions/sql-expression-schema.md
##########
@@ -2,7 +2,7 @@
 ## Summary
   - Number of queries: 336
   - Number of expressions that missing example: 34
-  - Expressions missing examples: and,string,tinyint,double,smallint,date,decimal,boolean,float,binary,bigint,int,timestamp,cume_dist,dense_rank,input_file_block_length,input_file_block_start,input_file_name,lag,lead,monotonically_increasing_id,ntile,struct,!,not,or,percent_rank,rank,row_number,spark_partition_id,version,window,positive,count_min_sketch
+  - Expressions missing examples: and,string,tinyint,double,smallint,date,decimal,boolean,float,binary,bigint,int,timestamp,struct,cume_dist,dense_rank,input_file_block_length,input_file_block_start,input_file_name,lag,lead,monotonically_increasing_id,ntile,!,not,or,percent_rank,rank,row_number,spark_partition_id,version,window,positive,count_min_sketch

Review comment:
       While you're in the same file, does it make sense to also add an example for this expression? I think you would only need to change line 333 in `sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org