You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by rb...@locus.apache.org on 2000/06/12 06:17:48 UTC

cvs commit: apache-2.0/src/modules/standard mod_cern_meta.c mod_cgi.c

rbb         00/06/11 21:17:47

  Modified:    src      configure.in
               src/modules/standard mod_cern_meta.c mod_cgi.c
  Log:
  Nothing in Apache should be calling stat anymore, so we can remove
  the check for sys/stat.h and all references to the resulting macro.
  
  Revision  Changes    Path
  1.56      +0 -1      apache-2.0/src/configure.in
  
  Index: configure.in
  ===================================================================
  RCS file: /home/cvs/apache-2.0/src/configure.in,v
  retrieving revision 1.55
  retrieving revision 1.56
  diff -u -r1.55 -r1.56
  --- configure.in	2000/06/12 03:35:13	1.55
  +++ configure.in	2000/06/12 04:17:44	1.56
  @@ -71,7 +71,6 @@
   ctype.h \
   limits.h \
   unistd.h \
  -sys/stat.h \
   sys/time.h \
   sys/types.h \
   sys/socket.h \
  
  
  
  1.15      +0 -3      apache-2.0/src/modules/standard/mod_cern_meta.c
  
  Index: mod_cern_meta.c
  ===================================================================
  RCS file: /home/cvs/apache-2.0/src/modules/standard/mod_cern_meta.c,v
  retrieving revision 1.14
  retrieving revision 1.15
  diff -u -r1.14 -r1.15
  --- mod_cern_meta.c	2000/05/27 22:40:35	1.14
  +++ mod_cern_meta.c	2000/06/12 04:17:45	1.15
  @@ -158,9 +158,6 @@
   #ifdef HAVE_SYS_TYPES_H
   #include <sys/types.h>
   #endif
  -#ifdef HAVE_SYS_STAT_H
  -#include <sys/stat.h>
  -#endif
   
   #define DIR_CMD_PERMS OR_INDEXES
   
  
  
  
  1.49      +0 -3      apache-2.0/src/modules/standard/mod_cgi.c
  
  Index: mod_cgi.c
  ===================================================================
  RCS file: /home/cvs/apache-2.0/src/modules/standard/mod_cgi.c,v
  retrieving revision 1.48
  retrieving revision 1.49
  diff -u -r1.48 -r1.49
  --- mod_cgi.c	2000/06/06 21:45:14	1.48
  +++ mod_cgi.c	2000/06/12 04:17:45	1.49
  @@ -81,9 +81,6 @@
   #include "http_log.h"
   #include "util_script.h"
   #include "http_conf_globals.h"
  -#ifdef HAVE_SYS_STAT_H
  -#include <sys/stat.h>
  -#endif
   #ifdef HAVE_STRING_H
   #include <string.h>
   #endif
  
  
  

Re: cvs commit: apache-2.0/src/modules/standard mod_cern_meta.c mod_cgi.c

Posted by rb...@covalent.net.
> > >     main/http_request.c and main/util.c still use lstat and stat.
> > >     Also, ap_config.h still contains
> > 
> > I am fixing that now.  And neither of these used HAVE_SYS_STAT_H
> 
>     Yes, because they both, directly or indirectly, included
>     ap_config.h

It's not a real issue, because I am in the middle of fixing both of
these.  Expect this to be done in about an hour.  This was still compiling
cleanly on my machine last night.

Ryan

_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Re: cvs commit: apache-2.0/src/modules/standard mod_cern_meta.c mod_cgi.c

Posted by Sascha Schumann <sa...@schumann.cx>.
On Mon, 12 Jun 2000 rbb@covalent.net wrote:

> 
> > >   Modified:    src      configure.in
> > >                src/modules/standard mod_cern_meta.c mod_cgi.c
> > >   Log:
> > >   Nothing in Apache should be calling stat anymore, so we can remove
> > >   the check for sys/stat.h and all references to the resulting macro.
> > 
> >     main/http_request.c and main/util.c still use lstat and stat.
> >     Also, ap_config.h still contains
> 
> I am fixing that now.  And neither of these used HAVE_SYS_STAT_H

    Yes, because they both, directly or indirectly, included
    ap_config.h

    - Sascha


Re: cvs commit: apache-2.0/src/modules/standard mod_cern_meta.c mod_cgi.c

Posted by rb...@covalent.net.
> >   Modified:    src      configure.in
> >                src/modules/standard mod_cern_meta.c mod_cgi.c
> >   Log:
> >   Nothing in Apache should be calling stat anymore, so we can remove
> >   the check for sys/stat.h and all references to the resulting macro.
> 
>     main/http_request.c and main/util.c still use lstat and stat.
>     Also, ap_config.h still contains

I am fixing that now.  And neither of these used HAVE_SYS_STAT_H

> 
>     #ifdef HAVE_SYS_STAT_H
>     include <sys/stat.h>
>     #endif

Hmmm...   That didn't show up in my grep.  It'll be removed in the next
commit.

Ryan

_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Re: cvs commit: apache-2.0/src/modules/standard mod_cern_meta.c mod_cgi.c

Posted by Sascha Schumann <sa...@schumann.cx>.
On 12 Jun 2000 rbb@locus.apache.org wrote:

> rbb         00/06/11 21:17:47
> 
>   Modified:    src      configure.in
>                src/modules/standard mod_cern_meta.c mod_cgi.c
>   Log:
>   Nothing in Apache should be calling stat anymore, so we can remove
>   the check for sys/stat.h and all references to the resulting macro.

    main/http_request.c and main/util.c still use lstat and stat.
    Also, ap_config.h still contains

    #ifdef HAVE_SYS_STAT_H
    include <sys/stat.h>
    #endif

    - Sascha