You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Jochen Wiedmann <jo...@gmail.com> on 2008/01/01 21:06:31 UTC
[VOTE] Release commons-fileupload 1.2.1 (rc2)
Hi,
I have prepared a second release candidate of commons-fileupload
1.2.1. A list of changes since rc1 and things that I haven't changes,
can be found below.
Thanks,
Jochen
[ ] +1
[ ] =0
[ ] -1
> There's a minor problem with the hashes.
> The hash shold be followed by a single space, and then the flag which
> is '*' for binary (space for text), followed by the filename.
This should be as requested now. I'd like to point out, that I find
such a specific format more than inconenient. No program that I am
aware of, creates this format. It should be sufficient to have the
first word (the actual checksum) right.
> The version does not appear in the download section on the home page
> as a release or release candidate.
Fixed.
> The changes report does not show 1.2.1. Several changes are shown for
> 1.3 - should that be 1.2.1?
Fixed.
> The pom.xml is missing the license header.
Fixed.
> The maven 1 build declares its version as 1.3-SNAPSHOT and has a
> dependency to commons-io 1.4-SNAPSHOT. In the <versions> section
> an element for the current release is missing.
Fixed.
> The ant build also produces an artifact with the version number
> 1.3-SNAPSHOT.
Fixed.
> There are 40 checkstyle errors in the report.
Reduced to 6, which are basically insufficiencies of checkstyle.
> When trying the m2 build I got the error that commons-io 1.3.2 could
> not be downloaded. Indeed this version does not seem to be in the
> central maven repository. Does anybody know why this is the case?
Fixed the groupId to org.apache.commons.
> It is kept, if the comment with the license is put after the project tag.
The license in the POM file is now immediately after the "project" tag,
I haven't responded to the following suggestions, though:
> The HTML title is a bit inconsistent in the reports section. Most of
> the pages on the site have a title of the form:
> FileUpload - sectionname - Browser name
> [The current website has FileUpload in the second position, but the
> new layout is better]
> However some of the Report section names don't show up in the title.
> This affects:
> Changes Report
> Clirr
> Jira Report
> Maven Surefire
> It's not at all clear what the Jira Report relates to.
> Also its entries don't seem to be in any particular order.
> Won't Fix is shown as Won ' t Fix which looks rather odd.
> It would help to show the Type and perhaps Priority of the issues.
> Rather a lot of blank space in the "Anonymous access" section in:
> http://people.apache.org/~jochen/commons-fileupload/\site/source-repository.html
These are all created with the standard Maven 2 with the settings as
specified in commons-parent pom, version 5. I have no intention to
change this per project.
> The SVN links all point to the tag 1.2.1RC1 - I wonder whether it
> might not be better to point to the parent directory which contains
> tags/branches and trunk?
My intention is to copy the rc2 tag to the final tag upon a positive
vote. I see no other way to create the distributables now without
moving svn tags.
--
Look, that's why there's rules, understand? So that you think before
you break 'em.
-- (Terry Pratchett, Thief of Time)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [all] Maven repo trouble? [was Re: [VOTE] Release commons-fileupload 1.2.1 (rc2)]
Posted by Henri Yandell <fl...@gmail.com>.
On Jan 1, 2008 12:57 PM, Jochen Wiedmann <jo...@gmail.com> wrote:
> On Jan 1, 2008 9:49 PM, Stephen Colebourne <sc...@btopenworld.com> wrote:
>
> > Hmmmm. It looks like something in maven is screwed.
>
> Rats! It's not in Maven.
>
> The pom file is below org.apache.commons, but the groupId in the pom
> file is commons-io.
>
> I'll copy the pom file and the jar file to commons-io/commons-io.
> Additionally, I'll discard the rc2 of commons-fileupload and create a
> new rc3 with the groupId commons-io. Sorry for all the hazzle!
>
> But I really wonder when we'll finally get rid of the commons-foo
> groupId's. IMO, we have wasted much more time with conserving them
> than we would have wasted with switching early. :-(
Post switching, every release requires a redirect pom being created.
Pre switching, no redirect poms are needed.
What effort has been spent (let alone wasted) with the exception of
email conversations?
Hen
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [all] Maven repo trouble? [was Re: [VOTE] Release commons-fileupload 1.2.1 (rc2)]
Posted by Jochen Wiedmann <jo...@gmail.com>.
On Jan 1, 2008 9:49 PM, Stephen Colebourne <sc...@btopenworld.com> wrote:
> Hmmmm. It looks like something in maven is screwed.
Rats! It's not in Maven.
The pom file is below org.apache.commons, but the groupId in the pom
file is commons-io.
I'll copy the pom file and the jar file to commons-io/commons-io.
Additionally, I'll discard the rc2 of commons-fileupload and create a
new rc3 with the groupId commons-io. Sorry for all the hazzle!
But I really wonder when we'll finally get rid of the commons-foo
groupId's. IMO, we have wasted much more time with conserving them
than we would have wasted with switching early. :-(
Jochen
--
Look, that's why there's rules, understand? So that you think before
you break 'em.
-- (Terry Pratchett, Thief of Time)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[all] Maven repo trouble? [was Re: [VOTE] Release commons-fileupload
1.2.1 (rc2)]
Posted by Stephen Colebourne <sc...@btopenworld.com>.
Jochen Wiedmann wrote:
>> When trying the m2 build I got the error that commons-io 1.3.2 could
>> not be downloaded. Indeed this version does not seem to be in the
>> central maven repository. Does anybody know why this is the case?
>
> Fixed the groupId to org.apache.commons.
Hmmmm. It looks like something in maven is screwed.
http://mirrors.ibiblio.org/pub/mirrors/maven2/org/apache/commons/commons-io/1.3.2/commons-io-1.3.2.pom
shows the commons-io groupId as commons-io. So why is it under
org.apache.commons and not commons-io?
The maven 1 repo - http://www.ibiblio.org/maven/commons-io/jars/ - shows
only release 1.3.1. There is no 1.3.2 in the maven 1 repo, only in the
maven 2 repo.
In fact, more generally, none of the maven 2 released commons jars are
in the maven 1 repo.
For [io] 1.3.2, it should never appear under org.apache.commons as it
was just a minor release, and 1.3.1 is under commons-io. (I think we all
agreed that it needed a more major release to change the group id)
Any views on this latest maven problem?
Stephen
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release commons-fileupload 1.2.1 (rc2)
Posted by sebb <se...@gmail.com>.
On 02/01/2008, Jochen Wiedmann <jo...@gmail.com> wrote:
> On Jan 2, 2008 8:07 PM, sebb <se...@gmail.com> wrote:
>
> > The format is used by the following programs:
> >
> > md5sum.exe - e.g. http://www.openoffice.org/dev_docs/using_md5sums.html
>
> jwi@mcjwi:~$ md5sum derby.log
> 6fce75e538c458f732d622e0a1d4bbdf derby.log
>
> Multiple blanks, no asterisk
The format is blank+flag; the flag may be blank itself. So two spaces
is OK, more is not.
>
> > md5 (windows and Un*x) - e.g. http://www.fourmilab.ch/md5/
>
> [jochen@minotaur ~]$ md5 source-repository.html
> MD5 (source-repository.html) = ea0e2875b98cad75e160b8b53cde4c93
>
> Completely different.
>
>
Try md5 -r
>
> --
> Look, that's why there's rules, understand? So that you think before
> you break 'em.
>
> -- (Terry Pratchett, Thief of Time)
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release commons-fileupload 1.2.1 (rc2)
Posted by Jochen Wiedmann <jo...@gmail.com>.
On Jan 2, 2008 8:07 PM, sebb <se...@gmail.com> wrote:
> The format is used by the following programs:
>
> md5sum.exe - e.g. http://www.openoffice.org/dev_docs/using_md5sums.html
jwi@mcjwi:~$ md5sum derby.log
6fce75e538c458f732d622e0a1d4bbdf derby.log
Multiple blanks, no asterisk
> md5 (windows and Un*x) - e.g. http://www.fourmilab.ch/md5/
[jochen@minotaur ~]$ md5 source-repository.html
MD5 (source-repository.html) = ea0e2875b98cad75e160b8b53cde4c93
Completely different.
--
Look, that's why there's rules, understand? So that you think before
you break 'em.
-- (Terry Pratchett, Thief of Time)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release commons-fileupload 1.2.1 (rc2)
Posted by sebb <se...@gmail.com>.
On 01/01/2008, Jochen Wiedmann <jo...@gmail.com> wrote:
> Hi,
>
> I have prepared a second release candidate of commons-fileupload
> 1.2.1. A list of changes since rc1 and things that I haven't changes,
> can be found below.
>
> Thanks,
>
> Jochen
>
>
> [ ] +1
> [ ] =0
> [ ] -1
>
>
>
>
>
> > There's a minor problem with the hashes.
> > The hash shold be followed by a single space, and then the flag which
> > is '*' for binary (space for text), followed by the filename.
>
> This should be as requested now. I'd like to point out, that I find
> such a specific format more than inconenient. No program that I am
> aware of, creates this format. It should be sufficient to have the
> first word (the actual checksum) right.
>
The format is used by the following programs:
md5sum.exe - e.g. http://www.openoffice.org/dev_docs/using_md5sums.html
md5 (windows and Un*x) - e.g. http://www.fourmilab.ch/md5/
There are probably others that use the same format.
==
Having just the checksum is OK, as the files contain only a single hash.
What was not OK with the original format was the additional space,
which caused problems for at least one of the programs mentioned
above.
> > The version does not appear in the download section on the home page
> > as a release or release candidate.
>
> Fixed.
>
> > The changes report does not show 1.2.1. Several changes are shown for
> > 1.3 - should that be 1.2.1?
>
> Fixed.
>
> > The pom.xml is missing the license header.
>
> Fixed.
>
> > The maven 1 build declares its version as 1.3-SNAPSHOT and has a
> > dependency to commons-io 1.4-SNAPSHOT. In the <versions> section
> > an element for the current release is missing.
>
> Fixed.
>
> > The ant build also produces an artifact with the version number
> > 1.3-SNAPSHOT.
>
> Fixed.
>
> > There are 40 checkstyle errors in the report.
>
> Reduced to 6, which are basically insufficiencies of checkstyle.
>
> > When trying the m2 build I got the error that commons-io 1.3.2 could
> > not be downloaded. Indeed this version does not seem to be in the
> > central maven repository. Does anybody know why this is the case?
>
> Fixed the groupId to org.apache.commons.
>
> > It is kept, if the comment with the license is put after the project tag.
>
> The license in the POM file is now immediately after the "project" tag,
>
>
> I haven't responded to the following suggestions, though:
>
> > The HTML title is a bit inconsistent in the reports section. Most of
> > the pages on the site have a title of the form:
>
> > FileUpload - sectionname - Browser name
>
> > [The current website has FileUpload in the second position, but the
> > new layout is better]
>
> > However some of the Report section names don't show up in the title.
> > This affects:
> > Changes Report
> > Clirr
> > Jira Report
> > Maven Surefire
>
> > It's not at all clear what the Jira Report relates to.
> > Also its entries don't seem to be in any particular order.
> > Won't Fix is shown as Won ' t Fix which looks rather odd.
> > It would help to show the Type and perhaps Priority of the issues.
>
> > Rather a lot of blank space in the "Anonymous access" section in:
> > http://people.apache.org/~jochen/commons-fileupload/\site/source-repository.html
>
> These are all created with the standard Maven 2 with the settings as
> specified in commons-parent pom, version 5. I have no intention to
> change this per project.
>
> > The SVN links all point to the tag 1.2.1RC1 - I wonder whether it
> > might not be better to point to the parent directory which contains
> > tags/branches and trunk?
>
> My intention is to copy the rc2 tag to the final tag upon a positive
> vote. I see no other way to create the distributables now without
> moving svn tags.
>
> --
> Look, that's why there's rules, understand? So that you think before
> you break 'em.
>
> -- (Terry Pratchett, Thief of Time)
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release commons-fileupload 1.2.1 (rc2)
Posted by sebb <se...@gmail.com>.
Just noticed that NOTICE.txt says:
Copyright 2002-2007 The Apache Software Foundation
There are probably some other instances of 2007 which need to be updated.
On 03/01/2008, Oliver Heger <ol...@oliver-heger.de> wrote:
> The source distros look okay, but can it be that the binary distros are
> missing the binaries? Both the zip and the tar.gz only contain LICENSE
> and NOTICE and the site directory.
>
> Other than that I only found a few (very minor) points:
> - When building with the different build systems the resulting jar does
> not always include the license files: The maven 1 build is okay, the
> maven 2 build does not include LICENSE and NOTICE, and the ant build
> only includes NOTICE.
>
> - On the site, the clirr report only shows a blanc page. (Well, this is
> probably a good sign, but a bit strange ;-)
>
> Oliver
>
> Jochen Wiedmann wrote:
> > Hi,
> >
> > I have prepared a second release candidate of commons-fileupload
> > 1.2.1. A list of changes since rc1 and things that I haven't changes,
> > can be found below.
> >
> > Thanks,
> >
> > Jochen
> >
> >
> > [ ] +1
> > [ ] =0
> > [ ] -1
> >
> >
> >
> >
> >
> >
> >>There's a minor problem with the hashes.
> >>The hash shold be followed by a single space, and then the flag which
> >>is '*' for binary (space for text), followed by the filename.
> >
> >
> > This should be as requested now. I'd like to point out, that I find
> > such a specific format more than inconenient. No program that I am
> > aware of, creates this format. It should be sufficient to have the
> > first word (the actual checksum) right.
> >
> >
> >>The version does not appear in the download section on the home page
> >>as a release or release candidate.
> >
> >
> > Fixed.
> >
> >
> >>The changes report does not show 1.2.1. Several changes are shown for
> >>1.3 - should that be 1.2.1?
> >
> >
> > Fixed.
> >
> >
> >>The pom.xml is missing the license header.
> >
> >
> > Fixed.
> >
> >
> >>The maven 1 build declares its version as 1.3-SNAPSHOT and has a
> >>dependency to commons-io 1.4-SNAPSHOT. In the <versions> section
> >>an element for the current release is missing.
> >
> >
> > Fixed.
> >
> >
> >>The ant build also produces an artifact with the version number
> >>1.3-SNAPSHOT.
> >
> >
> > Fixed.
> >
> >
> >>There are 40 checkstyle errors in the report.
> >
> >
> > Reduced to 6, which are basically insufficiencies of checkstyle.
> >
> >
> >>When trying the m2 build I got the error that commons-io 1.3.2 could
> >>not be downloaded. Indeed this version does not seem to be in the
> >>central maven repository. Does anybody know why this is the case?
> >
> >
> > Fixed the groupId to org.apache.commons.
> >
> >
> >>It is kept, if the comment with the license is put after the project tag.
> >
> >
> > The license in the POM file is now immediately after the "project" tag,
> >
> >
> > I haven't responded to the following suggestions, though:
> >
> >
> >>The HTML title is a bit inconsistent in the reports section. Most of
> >>the pages on the site have a title of the form:
> >
> >
> >>FileUpload - sectionname - Browser name
> >
> >
> >>[The current website has FileUpload in the second position, but the
> >>new layout is better]
> >
> >
> >>However some of the Report section names don't show up in the title.
> >>This affects:
> >>Changes Report
> >>Clirr
> >>Jira Report
> >>Maven Surefire
> >
> >
> >>It's not at all clear what the Jira Report relates to.
> >>Also its entries don't seem to be in any particular order.
> >>Won't Fix is shown as Won ' t Fix which looks rather odd.
> >>It would help to show the Type and perhaps Priority of the issues.
> >
> >
> >>Rather a lot of blank space in the "Anonymous access" section in:
> >>http://people.apache.org/~jochen/commons-fileupload/\site/source-repository.html
> >
> >
> > These are all created with the standard Maven 2 with the settings as
> > specified in commons-parent pom, version 5. I have no intention to
> > change this per project.
> >
> >
> >
> >>The SVN links all point to the tag 1.2.1RC1 - I wonder whether it
> >>might not be better to point to the parent directory which contains
> >>tags/branches and trunk?
> >
> >
> > My intention is to copy the rc2 tag to the final tag upon a positive
> > vote. I see no other way to create the distributables now without
> > moving svn tags.
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release commons-fileupload 1.2.1 (rc2)
Posted by Oliver Heger <ol...@oliver-heger.de>.
The source distros look okay, but can it be that the binary distros are
missing the binaries? Both the zip and the tar.gz only contain LICENSE
and NOTICE and the site directory.
Other than that I only found a few (very minor) points:
- When building with the different build systems the resulting jar does
not always include the license files: The maven 1 build is okay, the
maven 2 build does not include LICENSE and NOTICE, and the ant build
only includes NOTICE.
- On the site, the clirr report only shows a blanc page. (Well, this is
probably a good sign, but a bit strange ;-)
Oliver
Jochen Wiedmann wrote:
> Hi,
>
> I have prepared a second release candidate of commons-fileupload
> 1.2.1. A list of changes since rc1 and things that I haven't changes,
> can be found below.
>
> Thanks,
>
> Jochen
>
>
> [ ] +1
> [ ] =0
> [ ] -1
>
>
>
>
>
>
>>There's a minor problem with the hashes.
>>The hash shold be followed by a single space, and then the flag which
>>is '*' for binary (space for text), followed by the filename.
>
>
> This should be as requested now. I'd like to point out, that I find
> such a specific format more than inconenient. No program that I am
> aware of, creates this format. It should be sufficient to have the
> first word (the actual checksum) right.
>
>
>>The version does not appear in the download section on the home page
>>as a release or release candidate.
>
>
> Fixed.
>
>
>>The changes report does not show 1.2.1. Several changes are shown for
>>1.3 - should that be 1.2.1?
>
>
> Fixed.
>
>
>>The pom.xml is missing the license header.
>
>
> Fixed.
>
>
>>The maven 1 build declares its version as 1.3-SNAPSHOT and has a
>>dependency to commons-io 1.4-SNAPSHOT. In the <versions> section
>>an element for the current release is missing.
>
>
> Fixed.
>
>
>>The ant build also produces an artifact with the version number
>>1.3-SNAPSHOT.
>
>
> Fixed.
>
>
>>There are 40 checkstyle errors in the report.
>
>
> Reduced to 6, which are basically insufficiencies of checkstyle.
>
>
>>When trying the m2 build I got the error that commons-io 1.3.2 could
>>not be downloaded. Indeed this version does not seem to be in the
>>central maven repository. Does anybody know why this is the case?
>
>
> Fixed the groupId to org.apache.commons.
>
>
>>It is kept, if the comment with the license is put after the project tag.
>
>
> The license in the POM file is now immediately after the "project" tag,
>
>
> I haven't responded to the following suggestions, though:
>
>
>>The HTML title is a bit inconsistent in the reports section. Most of
>>the pages on the site have a title of the form:
>
>
>>FileUpload - sectionname - Browser name
>
>
>>[The current website has FileUpload in the second position, but the
>>new layout is better]
>
>
>>However some of the Report section names don't show up in the title.
>>This affects:
>>Changes Report
>>Clirr
>>Jira Report
>>Maven Surefire
>
>
>>It's not at all clear what the Jira Report relates to.
>>Also its entries don't seem to be in any particular order.
>>Won't Fix is shown as Won ' t Fix which looks rather odd.
>>It would help to show the Type and perhaps Priority of the issues.
>
>
>>Rather a lot of blank space in the "Anonymous access" section in:
>>http://people.apache.org/~jochen/commons-fileupload/\site/source-repository.html
>
>
> These are all created with the standard Maven 2 with the settings as
> specified in commons-parent pom, version 5. I have no intention to
> change this per project.
>
>
>
>>The SVN links all point to the tag 1.2.1RC1 - I wonder whether it
>>might not be better to point to the parent directory which contains
>>tags/branches and trunk?
>
>
> My intention is to copy the rc2 tag to the final tag upon a positive
> vote. I see no other way to create the distributables now without
> moving svn tags.
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org