You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/02/20 21:34:57 UTC

[GitHub] [airflow] potiuk commented on pull request #29034: Add functionality for operators to template all eligible fields (apac…

potiuk commented on PR #29034:
URL: https://github.com/apache/airflow/pull/29034#issuecomment-1437576952

   > I have doubts making this an operator argument is the right design. I’d want to make this designed at the operator class level, e.g.
   
   Agree with @uranusjr that class level field is better. Also we should allow (and document) the use of it in this form in DAG:
   
   
   ```python
   BashOperator.template_all_fields = True
   BashOperator.exclude_fields_from_template = []
   
   with DAG(....
   ````
   
   Then we would not have to convert all operators, but the user, when writing a DAG will not have to create a custom operator to template all fields. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org