[dubbo-admin] branch develop updated: change to constructor autowiring mode for MetricsCollectController.java (#622)

[hy...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

hyunkun pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/dubbo-admin.git


The following commit(s) were added to refs/heads/develop by this push:
     new c67832e  change to constructor autowiring mode for MetricsCollectController.java (#622)
c67832e is described below

commit c67832ed8473274cebc65c00d4cbe7f0dbe41213
Author: chenlongxing112 <ch...@gmail.com>
AuthorDate: Fri Jul 3 12:43:26 2020 +0800

    change to constructor autowiring mode for MetricsCollectController.java (#622)
---
 .../dubbo/admin/controller/MetricsCollectController.java       | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/dubbo-admin-server/src/main/java/org/apache/dubbo/admin/controller/MetricsCollectController.java b/dubbo-admin-server/src/main/java/org/apache/dubbo/admin/controller/MetricsCollectController.java
index 6acc0af..cdd129b 100644
--- a/dubbo-admin-server/src/main/java/org/apache/dubbo/admin/controller/MetricsCollectController.java
+++ b/dubbo-admin-server/src/main/java/org/apache/dubbo/admin/controller/MetricsCollectController.java
@@ -49,14 +49,16 @@ import java.util.Map;
 @RequestMapping("/api/{env}/metrics")
 public class MetricsCollectController {
 
-    @Autowired
     private ProviderService providerService;
-
-    @Autowired
     private ConsumerService consumerService;
+    private MetricsService metricsService;
 
     @Autowired
-    private MetricsService metricsService;
+    public MetricsCollectController(ProviderService providerService, ConsumerService consumerService, MetricsService metricsService) {
+        this.providerService = providerService;
+        this.consumerService = consumerService;
+        this.metricsService = metricsService;
+    }
 
     @RequestMapping(method = RequestMethod.POST)
     public String metricsCollect(@RequestParam String group, @PathVariable String env) {