You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/05/13 21:24:58 UTC
[GitHub] [flink] rudikershaw opened a new pull request, #19721: [hotfix][shell] Add stderr when 1 flink-dist*.jar cannot be resolved.
rudikershaw opened a new pull request, #19721:
URL: https://github.com/apache/flink/pull/19721
## What is the purpose of the change
When adding jars to the `/lib` directory any extra jar files that match the pattern `flink-dist*.jar` provoke an error when trying to use `BashJavaUtils` to get JVM parameters and dynamic configurations in `config.sh`. Although niche, this can be difficult to debug because there is no error message to describe the issue.
We already print a useful error message if no `flink-dist*.jar` can be found at all. This pull request adds another error message when more than one `flink-dist*.jar` is found at this point.
## Brief change log
- Fix minor typo in README.md
- Add error message for when more than one file matching `flink-dist*.jar` exists in `/lib`.
- Actioned a few minor shellcheck issues on the lines changed.
## Verifying this change
This change can be verified as follows:
- `./mvnw clean install -DskipTests -Dfast`
- `cp flink-dist-scala/target/flink-dist-scala_2.12-1.16-SNAPSHOT.jar build-target/lib/`
- `build-target/bin/start-cluster.sh`
- You should see the error message "[ERROR] Multiple flink-dist*.jar found in /path/to/lib. Please resolve."
- `rm build-target/lib/flink-dist-scala_2.12-1.16-SNAPSHOT.jar`
- `build-target/bin/start-cluster.sh`
- The cluster should start successfully.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): No
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: No
- The serializers: No
- The runtime per-record code paths (performance sensitive): No
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: No
- The S3 file system connector: No
## Documentation
- Does this pull request introduce a new feature? No
- If yes, how is the feature documented? Not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #19721: [hotfix][shell] Add stderr when 1 flink-dist*.jar cannot be resolved.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19721:
URL: https://github.com/apache/flink/pull/19721#issuecomment-1126523035
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "267285cd4cc39ebdc2846f8dfe3fe2a064a75b4c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "267285cd4cc39ebdc2846f8dfe3fe2a064a75b4c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 267285cd4cc39ebdc2846f8dfe3fe2a064a75b4c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rudikershaw commented on a diff in pull request #19721: [hotfix][shell] Add stderr when 1 flink-dist*.jar cannot be resolved.
Posted by GitBox <gi...@apache.org>.
rudikershaw commented on code in PR #19721:
URL: https://github.com/apache/flink/pull/19721#discussion_r872850362
##########
README.md:
##########
@@ -75,7 +75,7 @@ Prerequisites for building Flink:
```
git clone https://github.com/apache/flink.git
cd flink
-mvn clean package -DskipTests # this will take up to 10 minutes
+./mvnw clean package -DskipTests # this will take up to 10 minutes
Review Comment:
Switched to recommend using the project provided Maven wrapper. Later versions of Maven installed on a developer's computer will fail since the use of insecure repositories was depreciated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rudikershaw closed pull request #19721: [FLINK-27754][shell] Add stderr when 1 flink-dist*.jar cannot be resolved.
Posted by GitBox <gi...@apache.org>.
rudikershaw closed pull request #19721: [FLINK-27754][shell] Add stderr when 1 flink-dist*.jar cannot be resolved.
URL: https://github.com/apache/flink/pull/19721
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dannycranmer commented on pull request #19721: [hotfix][shell] Add stderr when 1 flink-dist*.jar cannot be resolved.
Posted by GitBox <gi...@apache.org>.
dannycranmer commented on PR #19721:
URL: https://github.com/apache/flink/pull/19721#issuecomment-1135583775
Thanks for the contribution @rudikershaw. LGTM, however as per the guidance, `[hotfix]` tag is mainly for documentation and typos. I understand this is a no-op change on the happy path, but please raise a Jira, rebase and add the Jira tag to the commit message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org