You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/04/08 07:27:11 UTC
[GitHub] [incubator-shardingsphere] kimmking opened a new pull request
#5104: Fix yaml meta data marshal
kimmking opened a new pull request #5104: Fix yaml meta data marshal
URL: https://github.com/apache/incubator-shardingsphere/pull/5104
Changes proposed in this pull request:
- Fix yaml meta data marshal
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #5104: Fix
yaml meta data marshal
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #5104: Fix yaml meta data marshal
URL: https://github.com/apache/incubator-shardingsphere/pull/5104#issuecomment-610850741
## Pull Request Test Coverage Report for [Build 10886](https://coveralls.io/builds/29932920)
* **0** of **35** **(0.0%)** changed or added relevant lines in **1** file are covered.
* **1** unchanged line in **1** file lost coverage.
* Overall coverage decreased (**-0.09%**) to **57.21%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-metadatacenter/src/main/java/org/apache/shardingsphere/orchestration/core/metadatacenter/yaml/RuleSchemaMetaDataYamlSwapper.java](https://coveralls.io/builds/29932920/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-metadatacenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fmetadatacenter%2Fyaml%2FRuleSchemaMetaDataYamlSwapper.java#L39) | 0 | 35 | 0.0%
<!-- | **Total:** | **0** | **35** | **0.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-metadatacenter/src/main/java/org/apache/shardingsphere/orchestration/core/metadatacenter/yaml/RuleSchemaMetaDataYamlSwapper.java](https://coveralls.io/builds/29932920/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-metadatacenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fmetadatacenter%2Fyaml%2FRuleSchemaMetaDataYamlSwapper.java#L43) | 1 | 0% |
<!-- | **Total:** | **1** | | -->
| Totals | [](https://coveralls.io/builds/29932920) |
| :-- | --: |
| Change from base [Build 10882](https://coveralls.io/builds/29930206): | -0.09% |
| Covered Lines: | 11668 |
| Relevant Lines: | 20395 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull
request #5104: Fix yaml meta data marshal
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #5104: Fix yaml meta data marshal
URL: https://github.com/apache/incubator-shardingsphere/pull/5104#discussion_r405357305
##########
File path: sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-metadatacenter/src/main/java/org/apache/shardingsphere/orchestration/core/metadatacenter/yaml/YamlTableMetaData.java
##########
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.orchestration.core.metadatacenter.yaml;
+
+import lombok.Getter;
+import lombok.Setter;
+import org.apache.shardingsphere.underlying.common.yaml.config.YamlConfiguration;
+
+import java.util.Map;
+
+/**
+ * Table Metadata configuration for yaml.
+ */
+@Getter
+@Setter
+public class YamlTableMetaData implements YamlConfiguration {
+
+ private Map<String, YamlColumnMetaData> columns;
+
+ private Map<String, YamlIndexMetaData> indexes;
+
Review comment:
please remove useless line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #5104: Fix
yaml meta data marshal
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #5104: Fix yaml meta data marshal
URL: https://github.com/apache/incubator-shardingsphere/pull/5104
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull
request #5104: Fix yaml meta data marshal
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #5104: Fix yaml meta data marshal
URL: https://github.com/apache/incubator-shardingsphere/pull/5104#discussion_r405370114
##########
File path: sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-metadatacenter/src/main/java/org/apache/shardingsphere/orchestration/core/metadatacenter/yaml/YamlTableMetaData.java
##########
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.orchestration.core.metadatacenter.yaml;
+
+import lombok.Getter;
+import lombok.Setter;
+import org.apache.shardingsphere.underlying.common.yaml.config.YamlConfiguration;
+
+import java.util.Map;
+
+/**
+ * Table Metadata configuration for yaml.
+ */
+@Getter
+@Setter
+public class YamlTableMetaData implements YamlConfiguration {
Review comment:
Please add final if class do not for extend
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services