You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/09/15 13:32:36 UTC

[GitHub] [beam] yeandy commented on a diff in pull request #23242: Fix type inference for set/delete attr.

yeandy commented on code in PR #23242:
URL: https://github.com/apache/beam/pull/23242#discussion_r971992233


##########
sdks/python/apache_beam/typehints/opcodes.py:
##########
@@ -241,8 +241,8 @@ def dup_topx(state, arg):
   state.stack += state[-arg:]
 
 
-store_attr = pop_top
-delete_attr = nop

Review Comment:
   Can you provide more context on this change? Where there any previous issues/failures?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org