You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Attila Bukor (Code Review)" <ge...@cloudera.org> on 2020/08/26 12:02:54 UTC
[kudu-CR] Upgrade docs/site building tools
Attila Bukor has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16371
Change subject: Upgrade docs/site building tools
......................................................................
Upgrade docs/site building tools
The tooling to build the documentation for the Kudu website are very
old making it difficult to run it on newer OSes.
This patch upgrades the Ruby dependencies along with the required
Doxygen version to make it easier. As the new dependencies are fairly
new, they require Ruby and Doxygen versions newer than what's included
by default on CentOS 7 and likely on other OSes that we might want to
use to build the site. It's fairly simple to upgrade them on the other
hand, this patch also adds instructions to README.adoc.
Change-Id: I5eddf689da90123ca52075d09de07981d11f8ffe
---
M CMakeLists.txt
M README.adoc
M docs/support/doxygen/client_api.doxy.in
M docs/support/scripts/Gemfile
M docs/support/scripts/Gemfile.lock
M docs/support/scripts/make_docs.sh
6 files changed, 79 insertions(+), 63 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/16371/1
--
To view, visit http://gerrit.cloudera.org:8080/16371
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5eddf689da90123ca52075d09de07981d11f8ffe
Gerrit-Change-Number: 16371
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
[kudu-CR] Upgrade docs/site building tools
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16371 )
Change subject: Upgrade docs/site building tools
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16371
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5eddf689da90123ca52075d09de07981d11f8ffe
Gerrit-Change-Number: 16371
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 27 Aug 2020 06:49:03 +0000
Gerrit-HasComments: No
[kudu-CR] Upgrade docs/site building tools
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16371 )
Change subject: Upgrade docs/site building tools
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/16371
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5eddf689da90123ca52075d09de07981d11f8ffe
Gerrit-Change-Number: 16371
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 26 Aug 2020 18:54:09 +0000
Gerrit-HasComments: No
[kudu-CR] Upgrade docs/site building tools
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16371
to look at the new patch set (#2).
Change subject: Upgrade docs/site building tools
......................................................................
Upgrade docs/site building tools
The tooling to build the documentation for the Kudu website are very
old making it difficult to run it on newer OSes.
This patch upgrades the Ruby dependencies along with the required
Doxygen version to make it easier. As the new dependencies are fairly
new, they require Ruby and Doxygen versions newer than what's included
by default on CentOS 7 and likely on other OSes that we might want to
use to build the site. It's fairly simple to upgrade them on the other
hand, this patch also adds instructions to README.adoc.
Change-Id: I5eddf689da90123ca52075d09de07981d11f8ffe
---
M CMakeLists.txt
M README.adoc
M docs/support/doxygen/client_api.doxy.in
M docs/support/scripts/Gemfile
M docs/support/scripts/Gemfile.lock
M docs/support/scripts/make_docs.sh
6 files changed, 104 insertions(+), 65 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/16371/2
--
To view, visit http://gerrit.cloudera.org:8080/16371
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5eddf689da90123ca52075d09de07981d11f8ffe
Gerrit-Change-Number: 16371
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] Upgrade docs/site building tools
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16371 )
Change subject: Upgrade docs/site building tools
......................................................................
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/16371/1/README.adoc
File README.adoc:
http://gerrit.cloudera.org:8080/#/c/16371/1/README.adoc@324
PS1, Line 324: build it from source
> Can you link to the instructions?
Done
http://gerrit.cloudera.org:8080/#/c/16371/1/README.adoc@326
PS1, Line 326: devtoolset-8
> We may require this for Kudu builds soon as well as I am working on bumping
Cool, in that case, this won't even be an extra dependency. We should still document it until then though, right?
http://gerrit.cloudera.org:8080/#/c/16371/1/docs/support/scripts/Gemfile
File docs/support/scripts/Gemfile:
http://gerrit.cloudera.org:8080/#/c/16371/1/docs/support/scripts/Gemfile@a26
PS1, Line 26:
> Does this mean Mac works again?
Yes, added warnings that it must not be built on Mac for publishing
http://gerrit.cloudera.org:8080/#/c/16371/1/docs/support/scripts/make_docs.sh
File docs/support/scripts/make_docs.sh:
http://gerrit.cloudera.org:8080/#/c/16371/1/docs/support/scripts/make_docs.sh@175
PS1, Line 175: set -x
> Did you intend to keep this? Should this be unset at any point?
Done
--
To view, visit http://gerrit.cloudera.org:8080/16371
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5eddf689da90123ca52075d09de07981d11f8ffe
Gerrit-Change-Number: 16371
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 26 Aug 2020 16:18:52 +0000
Gerrit-HasComments: Yes
[kudu-CR] Upgrade docs/site building tools
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16371 )
Change subject: Upgrade docs/site building tools
......................................................................
Upgrade docs/site building tools
The tooling to build the documentation for the Kudu website are very
old making it difficult to run it on newer OSes.
This patch upgrades the Ruby dependencies along with the required
Doxygen version to make it easier. As the new dependencies are fairly
new, they require Ruby and Doxygen versions newer than what's included
by default on CentOS 7 and likely on other OSes that we might want to
use to build the site. It's fairly simple to upgrade them on the other
hand, this patch also adds instructions to README.adoc.
Change-Id: I5eddf689da90123ca52075d09de07981d11f8ffe
Reviewed-on: http://gerrit.cloudera.org:8080/16371
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M CMakeLists.txt
M README.adoc
M RELEASING.adoc
M docs/support/doxygen/client_api.doxy.in
M docs/support/scripts/Gemfile
M docs/support/scripts/Gemfile.lock
M docs/support/scripts/make_docs.sh
7 files changed, 112 insertions(+), 67 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/16371
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5eddf689da90123ca52075d09de07981d11f8ffe
Gerrit-Change-Number: 16371
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] Upgrade docs/site building tools
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16371 )
Change subject: Upgrade docs/site building tools
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16371/3/docs/support/scripts/make_docs.sh
File docs/support/scripts/make_docs.sh:
http://gerrit.cloudera.org:8080/#/c/16371/3/docs/support/scripts/make_docs.sh@43
PS3, Line 43: -ne
Does '-ne' actually work against strings?
--
To view, visit http://gerrit.cloudera.org:8080/16371
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5eddf689da90123ca52075d09de07981d11f8ffe
Gerrit-Change-Number: 16371
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 26 Aug 2020 18:39:57 +0000
Gerrit-HasComments: Yes
[kudu-CR] Upgrade docs/site building tools
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16371
to look at the new patch set (#3).
Change subject: Upgrade docs/site building tools
......................................................................
Upgrade docs/site building tools
The tooling to build the documentation for the Kudu website are very
old making it difficult to run it on newer OSes.
This patch upgrades the Ruby dependencies along with the required
Doxygen version to make it easier. As the new dependencies are fairly
new, they require Ruby and Doxygen versions newer than what's included
by default on CentOS 7 and likely on other OSes that we might want to
use to build the site. It's fairly simple to upgrade them on the other
hand, this patch also adds instructions to README.adoc.
Change-Id: I5eddf689da90123ca52075d09de07981d11f8ffe
---
M CMakeLists.txt
M README.adoc
M RELEASING.adoc
M docs/support/doxygen/client_api.doxy.in
M docs/support/scripts/Gemfile
M docs/support/scripts/Gemfile.lock
M docs/support/scripts/make_docs.sh
7 files changed, 112 insertions(+), 67 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/16371/3
--
To view, visit http://gerrit.cloudera.org:8080/16371
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5eddf689da90123ca52075d09de07981d11f8ffe
Gerrit-Change-Number: 16371
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] Upgrade docs/site building tools
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Grant Henke, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16371
to look at the new patch set (#4).
Change subject: Upgrade docs/site building tools
......................................................................
Upgrade docs/site building tools
The tooling to build the documentation for the Kudu website are very
old making it difficult to run it on newer OSes.
This patch upgrades the Ruby dependencies along with the required
Doxygen version to make it easier. As the new dependencies are fairly
new, they require Ruby and Doxygen versions newer than what's included
by default on CentOS 7 and likely on other OSes that we might want to
use to build the site. It's fairly simple to upgrade them on the other
hand, this patch also adds instructions to README.adoc.
Change-Id: I5eddf689da90123ca52075d09de07981d11f8ffe
---
M CMakeLists.txt
M README.adoc
M RELEASING.adoc
M docs/support/doxygen/client_api.doxy.in
M docs/support/scripts/Gemfile
M docs/support/scripts/Gemfile.lock
M docs/support/scripts/make_docs.sh
7 files changed, 112 insertions(+), 67 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/16371/4
--
To view, visit http://gerrit.cloudera.org:8080/16371
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5eddf689da90123ca52075d09de07981d11f8ffe
Gerrit-Change-Number: 16371
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] Upgrade docs/site building tools
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16371 )
Change subject: Upgrade docs/site building tools
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/16371/1/README.adoc
File README.adoc:
http://gerrit.cloudera.org:8080/#/c/16371/1/README.adoc@326
PS1, Line 326: te, along wi
> yep, agreed.
Done
http://gerrit.cloudera.org:8080/#/c/16371/2/README.adoc
File README.adoc:
http://gerrit.cloudera.org:8080/#/c/16371/2/README.adoc@306
PS2, Line 306: WARNING: As the default values for some configuration options differ between Mac
: and Linux (e.g. file vs log block manager) and the configuration reference is
: generated by running the binaries with `-help`, the documentation *MUST NOT* be
: generated on Mac for publishing purposes, only for verification.
> Can you add this warning to the releasing doc too?
Done
--
To view, visit http://gerrit.cloudera.org:8080/16371
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5eddf689da90123ca52075d09de07981d11f8ffe
Gerrit-Change-Number: 16371
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 26 Aug 2020 18:12:51 +0000
Gerrit-HasComments: Yes
[kudu-CR] Upgrade docs/site building tools
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16371 )
Change subject: Upgrade docs/site building tools
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16371/1/README.adoc
File README.adoc:
http://gerrit.cloudera.org:8080/#/c/16371/1/README.adoc@324
PS1, Line 324: build it from source
> Done
For macOS an alternative is to install doxygen along with graphiz from MacPorts: this works for me. Probably, it works for brew as well (haven't checked brew since I'm using MacPorts).
--
To view, visit http://gerrit.cloudera.org:8080/16371
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5eddf689da90123ca52075d09de07981d11f8ffe
Gerrit-Change-Number: 16371
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 26 Aug 2020 18:32:52 +0000
Gerrit-HasComments: Yes
[kudu-CR] Upgrade docs/site building tools
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16371 )
Change subject: Upgrade docs/site building tools
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/16371/1/README.adoc
File README.adoc:
http://gerrit.cloudera.org:8080/#/c/16371/1/README.adoc@326
PS1, Line 326: docs/_ and _
> Cool, in that case, this won't even be an extra dependency. We should still
yep, agreed.
http://gerrit.cloudera.org:8080/#/c/16371/2/README.adoc
File README.adoc:
http://gerrit.cloudera.org:8080/#/c/16371/2/README.adoc@306
PS2, Line 306: WARNING: As the default values for some configuration options differ between Mac
: and Linux (e.g. file vs log block manager) and the configuration reference is
: generated by running the binaries with `-help`, the documentation *MUST NOT* be
: generated on Mac for publishing purposes, only for verification.
Can you add this warning to the releasing doc too?
--
To view, visit http://gerrit.cloudera.org:8080/16371
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5eddf689da90123ca52075d09de07981d11f8ffe
Gerrit-Change-Number: 16371
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 26 Aug 2020 17:59:02 +0000
Gerrit-HasComments: Yes
[kudu-CR] Upgrade docs/site building tools
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16371 )
Change subject: Upgrade docs/site building tools
......................................................................
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/16371/1/README.adoc
File README.adoc:
http://gerrit.cloudera.org:8080/#/c/16371/1/README.adoc@324
PS1, Line 324: ake_docs.sh` to gene
> For macOS an alternative is to install doxygen along with graphiz from MacP
Yea on Mac it works from Homebrew as well. My point is that in some cases (like on CentOS 7) we need to build from source and can't rely on the package manager as they ship an old version.
http://gerrit.cloudera.org:8080/#/c/16371/3/docs/support/scripts/make_docs.sh
File docs/support/scripts/make_docs.sh:
http://gerrit.cloudera.org:8080/#/c/16371/3/docs/support/scripts/make_docs.sh@43
PS3, Line 43: !=
> Does '-ne' actually work against strings?
No, it doesn't, you're right. Changed to "!="
--
To view, visit http://gerrit.cloudera.org:8080/16371
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5eddf689da90123ca52075d09de07981d11f8ffe
Gerrit-Change-Number: 16371
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 26 Aug 2020 22:15:14 +0000
Gerrit-HasComments: Yes
[kudu-CR] Upgrade docs/site building tools
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16371 )
Change subject: Upgrade docs/site building tools
......................................................................
Patch Set 1:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/16371/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/16371/1//COMMIT_MSG@13
PS1, Line 13: s the new dependencies are fairly
: new, they require Ruby and Doxygen versions newer than what's included
: by default on CentOS 7
I think this is okay given we plan to dockerize the docs/site build.
http://gerrit.cloudera.org:8080/#/c/16371/1/README.adoc
File README.adoc:
http://gerrit.cloudera.org:8080/#/c/16371/1/README.adoc@324
PS1, Line 324: build it from source
Can you link to the instructions?
http://gerrit.cloudera.org:8080/#/c/16371/1/README.adoc@326
PS1, Line 326: devtoolset-8
We may require this for Kudu builds soon as well as I am working on bumping the minimum GCC version.
http://gerrit.cloudera.org:8080/#/c/16371/1/docs/support/scripts/Gemfile
File docs/support/scripts/Gemfile:
http://gerrit.cloudera.org:8080/#/c/16371/1/docs/support/scripts/Gemfile@a26
PS1, Line 26:
Does this mean Mac works again?
http://gerrit.cloudera.org:8080/#/c/16371/1/docs/support/scripts/make_docs.sh
File docs/support/scripts/make_docs.sh:
http://gerrit.cloudera.org:8080/#/c/16371/1/docs/support/scripts/make_docs.sh@175
PS1, Line 175: set -x
Did you intend to keep this? Should this be unset at any point?
--
To view, visit http://gerrit.cloudera.org:8080/16371
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5eddf689da90123ca52075d09de07981d11f8ffe
Gerrit-Change-Number: 16371
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 26 Aug 2020 13:46:42 +0000
Gerrit-HasComments: Yes