You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ozone.apache.org by um...@apache.org on 2022/06/21 02:34:16 UTC

[ozone] branch master updated: HDDS-6899. [EC] Remove warnings and errors from console during online reconstruction of data. (#3522)

This is an automated email from the ASF dual-hosted git repository.

umamahesh pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ozone.git


The following commit(s) were added to refs/heads/master by this push:
     new bf71b54e2d HDDS-6899. [EC] Remove warnings and errors from console during online reconstruction of data. (#3522)
bf71b54e2d is described below

commit bf71b54e2d44711a1116aa8d38b398c4e7ebee6f
Author: swamirishi <47...@users.noreply.github.com>
AuthorDate: Mon Jun 20 19:34:11 2022 -0700

    HDDS-6899. [EC] Remove warnings and errors from console during online reconstruction of data. (#3522)
---
 .../java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java    |  8 +++++++-
 .../hadoop/ozone/client/io/ECBlockInputStreamProxy.java       | 11 +++++++++--
 2 files changed, 16 insertions(+), 3 deletions(-)

diff --git a/hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java b/hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java
index eea2bf37df..2402146116 100644
--- a/hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java
+++ b/hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java
@@ -280,7 +280,13 @@ public class XceiverClientGrpc extends XceiverClientSpi {
       // Re-interrupt the thread while catching InterruptedException
       Thread.currentThread().interrupt();
     } catch (ExecutionException e) {
-      LOG.error("Failed to execute command {}", processForDebug(request), e);
+      String message = "Failed to execute command {}.";
+      if (LOG.isDebugEnabled()) {
+        LOG.debug(message, processForDebug(request), e);
+      } else {
+        LOG.error(message + " Exception Class: {}, Exception Message: {}",
+                request.getCmdType(), e.getClass().getName(), e.getMessage());
+      }
     }
     return responseProtoHashMap;
   }
diff --git a/hadoop-hdds/client/src/main/java/org/apache/hadoop/ozone/client/io/ECBlockInputStreamProxy.java b/hadoop-hdds/client/src/main/java/org/apache/hadoop/ozone/client/io/ECBlockInputStreamProxy.java
index 49ee7c7538..5427e300ce 100644
--- a/hadoop-hdds/client/src/main/java/org/apache/hadoop/ozone/client/io/ECBlockInputStreamProxy.java
+++ b/hadoop-hdds/client/src/main/java/org/apache/hadoop/ozone/client/io/ECBlockInputStreamProxy.java
@@ -165,8 +165,15 @@ public class ECBlockInputStreamProxy extends BlockExtendedInputStream {
         throw e;
       }
       if (e instanceof BadDataLocationException) {
-        LOG.warn("Failing over to reconstruction read due to an error in " +
-            "ECBlockReader", e);
+        String message = "Failing over to reconstruction read due" +
+                " to an error in ECBlockReader.";
+        if (LOG.isDebugEnabled()) {
+          LOG.debug(message, e);
+        } else {
+          LOG.warn("{} Exception Class: {} , Exception Message: {}",
+                  message, e.getClass().getName(), e.getMessage());
+        }
+
         failoverToReconstructionRead(
             ((BadDataLocationException) e).getFailedLocation(), lastPosition);
         buf.reset();


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@ozone.apache.org
For additional commands, e-mail: commits-help@ozone.apache.org