You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/03/02 03:52:19 UTC

[GitHub] [incubator-iotdb] JackieTien97 commented on a change in pull request #864: [IOTDB-527] Refactor series reader

JackieTien97 commented on a change in pull request #864: [IOTDB-527] Refactor series reader
URL: https://github.com/apache/incubator-iotdb/pull/864#discussion_r386179745
 
 

 ##########
 File path: server/src/main/java/org/apache/iotdb/db/query/reader/series/SeriesReader.java
 ##########
 @@ -104,251 +130,274 @@ public SeriesReader(Path seriesPath, TSDataType dataType, QueryContext context,
 
 
   public boolean hasNextChunk() throws IOException {
-    if (hasCachedFirstChunkMetadata) {
-      return true;
 
 Review comment:
   It seems that if I keep calling hasNextChunk(), the firstChunkMetaData will move to next all the time.
   you can add an if statement.
   if (firstChunkMetaData != null)
       return true;

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services