You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/01/02 06:23:19 UTC
[GitHub] [skywalking] web-xiaxia opened a new pull request #4160: add
Dynamic Configuration Consul AclToken
web-xiaxia opened a new pull request #4160: add Dynamic Configuration Consul AclToken
URL: https://github.com/apache/skywalking/pull/4160
Please answer these questions before submitting pull request
- Why submit this pull request?
- [] Bug fix
- [x] New feature provided
- [] Improve performance
- Related issues
___
### Bug fix
- Bug description.
- How to fix?
___
### New feature or improvement
- Describe the details and related test reports.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] arugal commented on issue #4160: add Dynamic
Configuration Consul AclToken
Posted by GitBox <gi...@apache.org>.
arugal commented on issue #4160: add Dynamic Configuration Consul AclToken
URL: https://github.com/apache/skywalking/pull/4160#issuecomment-570127935
Compile failed, please recheck.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] web-xiaxia closed pull request #4160: add Dynamic
Configuration Consul AclToken
Posted by GitBox <gi...@apache.org>.
web-xiaxia closed pull request #4160: add Dynamic Configuration Consul AclToken
URL: https://github.com/apache/skywalking/pull/4160
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4160:
add Dynamic Configuration Consul AclToken
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4160: add Dynamic Configuration Consul AclToken
URL: https://github.com/apache/skywalking/pull/4160#discussion_r362380257
##########
File path: oap-server/server-bootstrap/src/main/resources/application.yml
##########
@@ -223,6 +223,8 @@ configuration:
# hostAndPorts: ${consul.address}
# # Sync period in seconds. Defaults to 60 seconds.
# period: 1
+# # Consul aclToken
+# #aclToken: ${consul.aclToken}
Review comment:
There is another application.yml in dist-material fold, please sync the change there too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4160: add Dynamic
Configuration Consul AclToken
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4160: add Dynamic Configuration Consul AclToken
URL: https://github.com/apache/skywalking/pull/4160#issuecomment-570137826
Why close this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4160:
add Dynamic Configuration Consul AclToken
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4160: add Dynamic Configuration Consul AclToken
URL: https://github.com/apache/skywalking/pull/4160#discussion_r362380189
##########
File path: oap-server/server-configuration/configuration-consul/src/main/java/org/apache/skywalking/oap/server/configuration/consul/ConsulConfigurationCenterSettings.java
##########
@@ -33,4 +33,8 @@
@Getter
@Setter
private String hostAndPorts;
+
+ @Getter
+ @Setter
+ private String aclTokne;
Review comment:
There is a typo here. Are you not using IDE?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services