You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "Jimmyweng006 (via GitHub)" <gi...@apache.org> on 2025/05/04 13:55:37 UTC
[PR] HDDS-12964. Add required docker compose version on Building From Sources Document [ozone]
Jimmyweng006 opened a new pull request, #8385:
URL: https://github.com/apache/ozone/pull/8385
## What changes were proposed in this pull request?
Add Docker Compose v2.32.1+ requirement to documentation
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-12964
## How was this patch tested?
Run command locally
[Github Action Pass](https://github.com/Jimmyweng006/ozone/actions/runs/14819591010)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12964. Add required docker compose version on Building From Sources Document [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #8385:
URL: https://github.com/apache/ozone/pull/8385#issuecomment-2867280258
Thanks a lot @Jimmyweng006 for updating the patch. Thanks @jojochuang for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12964. Add required docker compose version on Building From Sources Document [ozone]
Posted by "Jimmyweng006 (via GitHub)" <gi...@apache.org>.
Jimmyweng006 commented on PR #8385:
URL: https://github.com/apache/ozone/pull/8385#issuecomment-2849913887
Thanks @adoroszlai for the quick feedback!
1. I added this to the "Building From Sources" page since users need Docker Compose when building from the latest code.
2. I’m aware there is a V2 website, but I’m not sure if we still need to maintain the V1 website, or should we start putting new content only on the V2 website? If so, which page on the V2 site should correspond to "Building From Sources"? Or is the current "Try Ozone With Docker" page on the V2 website already sufficient?
3. I saw the v2.32.1 version mentioned in [the latest comment in this issue](https://github.com/docker/compose/issues/12123), but it seems the actual working version is the one you mentioned below:
[compose-go 2.3.0](https://github.com/compose-spec/compose-go/releases/tag/v2.3.0):
Reapply "accept dashes in variable names" by @ndeloof in https://github.com/compose-spec/compose-go/pull/683
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12964. Add required docker compose version on Building From Sources Document [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #8385:
URL: https://github.com/apache/ozone/pull/8385#issuecomment-2850003550
> 1. I added this to the "Building From Sources" page since users need Docker Compose when building from the latest code.
No. They need Docker Compose if they want to run Ozone in Docker Compose, regardless of building from source or using binary release tarball or pre-built Docker image.
> 2. I’m aware there is a V2 website, but I’m not sure if we still need to maintain the V1 website, or should we start putting new content only on the V2 website? If so, which page on the V2 site should correspond to "Building From Sources"? Or is the current "Try Ozone With Docker" page on the V2 website already sufficient?
Since this is a simple, clear change, I think it's OK to add it in the old doc, and we can either keep the new doc as is, or add the minimum version there, too.
> 3. I saw the v2.32.1 version mentioned in [the latest comment in this issue](https://github.com/docker/compose/issues/12123)
I think 2.32.1 just happened to be the version that person tried it with.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12964. Add required docker compose version on Building From Sources Document [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #8385:
URL: https://github.com/apache/ozone/pull/8385#issuecomment-2849267349
Thanks @Jimmyweng006 for working on this. Some observations:
1. I think [Pseudo-cluster](https://ozone.apache.org/docs/edge/start/runningviadocker.html) page is a better place for mentioning Docker Compose version requirement than Building From Sources.
2. Guide for Getting Started with Docker was migrated to the [new website](https://ozone-site-v2.staged.apache.org/docs/quick-start/installation/docker/), which mentions "latest stable version" as requirement.
3. Compose versions 2.30 or newer are fine, and there are several versions up to 2.29.2 that also worked. Current latest version is 2.35.1. So I'm not sure why 2.32.1 would be mentioned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12964. Add required docker compose version on Building From Sources Document [ozone]
Posted by "Jimmyweng006 (via GitHub)" <gi...@apache.org>.
Jimmyweng006 commented on PR #8385:
URL: https://github.com/apache/ozone/pull/8385#issuecomment-2866782665
I see the link to "RunningViaDocker" in "FromSource" page now... thanks @adoroszlai for pointing out and detailed explanation.
Since "FromSource" focus on how to build the code, I think I just put the docker version requirement on "RunningViaDocker".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12964. Add required docker compose version on Building From Sources Document [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #8385:
URL: https://github.com/apache/ozone/pull/8385#discussion_r2072892280
##########
hadoop-hdds/docs/content/start/FromSource.md:
##########
@@ -25,6 +25,7 @@ weight: 30
* JDK 1.8 or higher
* [Maven 3.6 or later](https://maven.apache.org/download.cgi)
* Internet connection for first build (to fetch all Maven and Ozone dependencies)
+* [Docker Compose v2.32.1 or higher](https://docs.docker.com/compose/install/) (to prevent unexpected character “-” in variable name issue)
Review Comment:
Also, I don't think we need to mention the specific problem.
```suggestion
* [Docker Compose v2.30 or newer](https://docs.docker.com/compose/install/)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12964. Add required docker compose version on Building From Sources Document [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #8385:
URL: https://github.com/apache/ozone/pull/8385
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12964. Add required docker compose version on Building From Sources Document [ozone]
Posted by "Jimmyweng006 (via GitHub)" <gi...@apache.org>.
Jimmyweng006 commented on code in PR #8385:
URL: https://github.com/apache/ozone/pull/8385#discussion_r2076623068
##########
hadoop-hdds/docs/content/start/FromSource.md:
##########
@@ -25,6 +25,7 @@ weight: 30
* JDK 1.8 or higher
* [Maven 3.6 or later](https://maven.apache.org/download.cgi)
* Internet connection for first build (to fetch all Maven and Ozone dependencies)
+* [Docker Compose v2.32.1 or higher](https://docs.docker.com/compose/install/) (to prevent unexpected character “-” in variable name issue)
Review Comment:
Got it, thanks @adoroszlai.
I push the new commit for that, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12964. Add required docker compose version on Building From Sources Document [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #8385:
URL: https://github.com/apache/ozone/pull/8385#discussion_r2072889007
##########
hadoop-hdds/docs/content/start/FromSource.md:
##########
@@ -25,6 +25,7 @@ weight: 30
* JDK 1.8 or higher
* [Maven 3.6 or later](https://maven.apache.org/download.cgi)
* Internet connection for first build (to fetch all Maven and Ozone dependencies)
+* [Docker Compose v2.32.1 or higher](https://docs.docker.com/compose/install/) (to prevent unexpected character “-” in variable name issue)
Review Comment:
No, the bug affects version range `[v2.29.3, v2.30.0)`, which excludes 2.30, the first version with the fix. So 2.30 or above should work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12964. Add required docker compose version on Building From Sources Document [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #8385:
URL: https://github.com/apache/ozone/pull/8385#discussion_r2072889007
##########
hadoop-hdds/docs/content/start/FromSource.md:
##########
@@ -25,6 +25,7 @@ weight: 30
* JDK 1.8 or higher
* [Maven 3.6 or later](https://maven.apache.org/download.cgi)
* Internet connection for first build (to fetch all Maven and Ozone dependencies)
+* [Docker Compose v2.32.1 or higher](https://docs.docker.com/compose/install/) (to prevent unexpected character “-” in variable name issue)
Review Comment:
No, the bug affects version range `[v2.29.3, v2.30.0)`, which excludes 2.30, the first version with the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12964. Add required docker compose version on Building From Sources Document [ozone]
Posted by "Jimmyweng006 (via GitHub)" <gi...@apache.org>.
Jimmyweng006 commented on PR #8385:
URL: https://github.com/apache/ozone/pull/8385#issuecomment-2863679853
I also found my previous statement was not clear.
> I added this to the "Building From Sources" page since users need Docker Compose when building from the latest code.
I want to put the docker version here since **How to run Ozone from build** section in this page uses the docker compose but without mentioning the version.
Should we add below information after line 32 in the FromSource.md?
```
If you want to run Ozone from build
* [Docker Compose](https://docs.docker.com/compose/install/) at least v2.30
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12964. Add required docker compose version on Building From Sources Document [ozone]
Posted by "Jimmyweng006 (via GitHub)" <gi...@apache.org>.
Jimmyweng006 commented on PR #8385:
URL: https://github.com/apache/ozone/pull/8385#issuecomment-2863657495
Oh I should write in the **RunningViaDocker** as well
* [Docker Engine](https://docs.docker.com/engine/install/) Latest stable version
* [Docker Compose](https://docs.docker.com/compose/install/) At least v2.30
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12964. Add required docker compose version on Building From Sources Document [ozone]
Posted by "jojochuang (via GitHub)" <gi...@apache.org>.
jojochuang commented on code in PR #8385:
URL: https://github.com/apache/ozone/pull/8385#discussion_r2072730248
##########
hadoop-hdds/docs/content/start/FromSource.md:
##########
@@ -25,6 +25,7 @@ weight: 30
* JDK 1.8 or higher
* [Maven 3.6 or later](https://maven.apache.org/download.cgi)
* Internet connection for first build (to fetch all Maven and Ozone dependencies)
+* [Docker Compose v2.32.1 or higher](https://docs.docker.com/compose/install/) (to prevent unexpected character “-” in variable name issue)
Review Comment:
According to https://issues.apache.org/jira/browse/HDDS-11590
Docker Compose v2.31 or above works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12964. Add required docker compose version on Building From Sources Document [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #8385:
URL: https://github.com/apache/ozone/pull/8385#issuecomment-2863793900
@Jimmyweng006 This is in the "From Source" page:
> ## How to run Ozone from build
> When you have the new distribution, you can start a local cluster [with docker-compose](https://ozone.apache.org/docs/1.4.1/start/runningviadocker.html).
It directs readers to the Pseudo-cluster (RunningViaDocker) page for more information about using `docker-compose`.
Users downloading the binary tarball from the website get the same structure as those who build it locally. So the same Docker Compose problem affects them as well. That's why I said it's not specific to building from sources.
But I guess it's OK to add to both pages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12964. Add required docker compose version on Building From Sources Document [ozone]
Posted by "jojochuang (via GitHub)" <gi...@apache.org>.
jojochuang commented on code in PR #8385:
URL: https://github.com/apache/ozone/pull/8385#discussion_r2072730248
##########
hadoop-hdds/docs/content/start/FromSource.md:
##########
@@ -25,6 +25,7 @@ weight: 30
* JDK 1.8 or higher
* [Maven 3.6 or later](https://maven.apache.org/download.cgi)
* Internet connection for first build (to fetch all Maven and Ozone dependencies)
+* [Docker Compose v2.32.1 or higher](https://docs.docker.com/compose/install/) (to prevent unexpected character “-” in variable name issue)
Review Comment:
According to https://issues.apache.org/jira/browse/HDDS-11590
Docker Compose v2.31 or above should works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12964. Add required docker compose version on Building From Sources Document [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #8385:
URL: https://github.com/apache/ozone/pull/8385#issuecomment-2857281672
> > 1. I added this to the "Building From Sources" page since users need Docker Compose when building from the latest code.
>
> No. They need Docker Compose if they want to run Ozone in Docker Compose, regardless of building from source or using binary release tarball or pre-built Docker image.
So can we move the requirement to
https://github.com/apache/ozone/blob/4775e76cfbd7ef9d0ad642021f55b4aa6fb9eb3d/hadoop-hdds/docs/content/start/RunningViaDocker.md?plain=1#L24
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12964. Add required docker compose version on Building From Sources Document [ozone]
Posted by "Jimmyweng006 (via GitHub)" <gi...@apache.org>.
Jimmyweng006 commented on PR #8385:
URL: https://github.com/apache/ozone/pull/8385#issuecomment-2868179120
Thanks @jojochuang and @adoroszlai for reviewing the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org