[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource

[GitBox <gi...@apache.org>]

jackjlli commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource
URL: https://github.com/apache/incubator-pinot/pull/4323#discussion_r296101035
 
 

 ##########
 File path: pinot-controller/src/main/java/org/apache/pinot/controller/ControllerLeadershipManager.java
 ##########
 @@ -1,117 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-package org.apache.pinot.controller;
-
-import java.util.HashMap;
-import java.util.Map;
-import javax.annotation.concurrent.ThreadSafe;
-import org.apache.helix.HelixManager;
-import org.apache.pinot.common.metrics.ControllerGauge;
-import org.apache.pinot.common.metrics.ControllerMetrics;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
-
-/**
- * Single place for listening on controller changes.
- * This should be created at controller startup and everyone who wants to listen to controller changes should subscribe.
- */
-@ThreadSafe
-public class ControllerLeadershipManager {
 
 Review comment:
   The behavior of running periodic tasks has changed. Previous it depends on the notification from controller listener. When it's Helix leader, we start periodic task scheduler; when it isn't, we stop periodic task scheduler.
   The code change here will always run the scheduler. Inside the for loop we call `_leadControllerManager.isLeaderForTable(tableNameWithType)` to determine whether we should use Partition leader or Helix leader.
   This class can still be useful for caching helix leader (which reduces ZK access) and emitting metric. I'll bring this class back and remove the logic with subscribers in the next push.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org