[GitHub] [superset] villebro commented on a diff in pull request #24477: fix: Total calculation in stacked Timeseries charts

["villebro (via GitHub)" <gi...@apache.org>]

villebro commented on code in PR #24477:
URL: https://github.com/apache/superset/pull/24477#discussion_r1239395231


##########
superset-frontend/packages/superset-ui-core/src/chart/models/ChartProps.ts:
##########
@@ -88,6 +95,8 @@ export interface ChartPropsConfig {
   ownState?: JsonObject;
   /** Filter state that saved in dashboard */
   filterState?: FilterState;
+  /** Legend state */
+  legendState?: LegendState;

Review Comment:
   I want to raise the concern of bloating the number of different states we have here: Would it make sense to introduce something more generic, like `chartState` that could be leveraged for transporting other info, too? I assume this isn't the last time we need to ship back info from the plugin to `transformProps`, and having to add a new property can become tedious at some point. Thoughts? Alternatively, let's not do this now, but do a full cleanup when we get around to building the new React-based plugin arch (v2).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org