You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/17 14:19:05 UTC
[GitHub] [camel-website] AemieJ opened a new pull request #228: CAMEL-14581:
Improve the accessibility factor under the blog section
AemieJ opened a new pull request #228: CAMEL-14581: Improve the accessibility factor under the blog section
URL: https://github.com/apache/camel-website/pull/228
* After running audit, it was observed that the accessibility factor under the blog section was decreasing due to various factors, one of them including the **color contrast**.
* For the case of **color contrast**, I have made all required changes to get the right **COLOR CONTRAST RATIO** while keeping in mind the aesthetic and presentability of the pages under the blog section.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] AemieJ commented on issue #228: CAMEL-14581:
Improve the accessibility factor under the blog section
Posted by GitBox <gi...@apache.org>.
AemieJ commented on issue #228: CAMEL-14581: Improve the accessibility factor under the blog section
URL: https://github.com/apache/camel-website/pull/228#issuecomment-604389879
> To me this doesn't have the same appeal as opposed to what we currently have. It's a bit disconcerting to have dark text on orange colour bit out of touch with the rest of the design.
> We need to take care of contrast but we also need to have a nice design, this doesn't look as nice to me.
I agree I will see if any change can be made such that the designing, as well as accessibility factor, is taken care of.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] AemieJ commented on a change in pull request #228:
CAMEL-14581: Improve the accessibility factor under the blog section
Posted by GitBox <gi...@apache.org>.
AemieJ commented on a change in pull request #228: CAMEL-14581: Improve the accessibility factor under the blog section
URL: https://github.com/apache/camel-website/pull/228#discussion_r400288499
##########
File path: antora-ui-camel/src/css/vars.css
##########
@@ -10,6 +10,7 @@
--color-gray-30: #8e8e8e;
--color-gray-50: #808080;
--color-gray-70: #5d5d5d;
+ --color-gray-90: #555;
Review comment:
**color-gray-70** is being used. I could make use of **color-gray-60** for this one, I feel.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#228: CAMEL-14581: Improve the accessibility factor under the blog section
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #228: CAMEL-14581: Improve the accessibility factor under the blog section
URL: https://github.com/apache/camel-website/pull/228#discussion_r400276752
##########
File path: antora-ui-camel/src/css/vars.css
##########
@@ -10,6 +10,7 @@
--color-gray-30: #8e8e8e;
--color-gray-50: #808080;
--color-gray-70: #5d5d5d;
+ --color-gray-90: #555;
Review comment:
This is 65% grey not 90%, perhaps we can use 70% instead of introducing this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] AemieJ closed pull request #228: CAMEL-14581:
Improve the accessibility factor under the blog section
Posted by GitBox <gi...@apache.org>.
AemieJ closed pull request #228: CAMEL-14581: Improve the accessibility factor under the blog section
URL: https://github.com/apache/camel-website/pull/228
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] AemieJ commented on a change in pull request #228:
CAMEL-14581: Improve the accessibility factor under the blog section
Posted by GitBox <gi...@apache.org>.
AemieJ commented on a change in pull request #228: CAMEL-14581: Improve the accessibility factor under the blog section
URL: https://github.com/apache/camel-website/pull/228#discussion_r400314290
##########
File path: antora-ui-camel/src/css/vars.css
##########
@@ -18,7 +19,10 @@
--color-black: #000;
--color-asf-dark-blue: #303284;
--color-asf-moderate-blue: #585ac2;
+ --color-bistre: #41250c;
--color-camel-orange: #ed8225;
+ --color-camel-vivid-orange: #e97826;
+ --color-dark-gray: #767676;
Review comment:
46% gray provides better and more sophisticated contrast than the current 50% gray.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] AemieJ commented on a change in pull request #228:
CAMEL-14581: Improve the accessibility factor under the blog section
Posted by GitBox <gi...@apache.org>.
AemieJ commented on a change in pull request #228: CAMEL-14581: Improve the accessibility factor under the blog section
URL: https://github.com/apache/camel-website/pull/228#discussion_r400287025
##########
File path: antora-ui-camel/src/css/vars.css
##########
@@ -18,7 +19,10 @@
--color-black: #000;
--color-asf-dark-blue: #303284;
--color-asf-moderate-blue: #585ac2;
+ --color-bistre: #41250c;
Review comment:
Yes sure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#228: CAMEL-14581: Improve the accessibility factor under the blog section
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #228: CAMEL-14581: Improve the accessibility factor under the blog section
URL: https://github.com/apache/camel-website/pull/228#discussion_r400218152
##########
File path: antora-ui-camel/src/css/vars.css
##########
@@ -18,7 +19,10 @@
--color-black: #000;
--color-asf-dark-blue: #303284;
--color-asf-moderate-blue: #585ac2;
+ --color-bistre: #41250c;
Review comment:
This one is not used, perhaps remove it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] AemieJ commented on a change in pull request #228:
CAMEL-14581: Improve the accessibility factor under the blog section
Posted by GitBox <gi...@apache.org>.
AemieJ commented on a change in pull request #228: CAMEL-14581: Improve the accessibility factor under the blog section
URL: https://github.com/apache/camel-website/pull/228#discussion_r400290907
##########
File path: antora-ui-camel/src/css/vars.css
##########
@@ -18,7 +19,10 @@
--color-black: #000;
--color-asf-dark-blue: #303284;
--color-asf-moderate-blue: #585ac2;
+ --color-bistre: #41250c;
--color-camel-orange: #ed8225;
+ --color-camel-vivid-orange: #e97826;
+ --color-dark-gray: #767676;
Review comment:
I will try to make use of the 50% gray and make changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] AemieJ commented on issue #228: CAMEL-14581:
Improve the accessibility factor under the blog section
Posted by GitBox <gi...@apache.org>.
AemieJ commented on issue #228: CAMEL-14581: Improve the accessibility factor under the blog section
URL: https://github.com/apache/camel-website/pull/228#issuecomment-604952500
I am currently making a change to improve the contrast ratio for the category links. I will try my best by today.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] AemieJ commented on issue #228: CAMEL-14581:
Improve the accessibility factor under the blog section
Posted by GitBox <gi...@apache.org>.
AemieJ commented on issue #228: CAMEL-14581: Improve the accessibility factor under the blog section
URL: https://github.com/apache/camel-website/pull/228#issuecomment-605011319
@zregvart I have made changes to the contrast ratio of the category links such that the color used goes smoothly with the design and increases the contrast ratio than the original one too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#228: CAMEL-14581: Improve the accessibility factor under the blog section
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #228: CAMEL-14581: Improve the accessibility factor under the blog section
URL: https://github.com/apache/camel-website/pull/228#discussion_r400272302
##########
File path: antora-ui-camel/src/css/vars.css
##########
@@ -18,7 +19,10 @@
--color-black: #000;
--color-asf-dark-blue: #303284;
--color-asf-moderate-blue: #585ac2;
+ --color-bistre: #41250c;
--color-camel-orange: #ed8225;
+ --color-camel-vivid-orange: #e97826;
+ --color-dark-gray: #767676;
Review comment:
Could we use one of the existing gray shades we have or keep all the grey variables together and with consistent naming. This is 46% gray could we use 50% or 30% instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #228: CAMEL-14581:
Improve the accessibility factor under the blog section
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #228: CAMEL-14581: Improve the accessibility factor under the blog section
URL: https://github.com/apache/camel-website/pull/228#issuecomment-604387114
Preview is [here](https://builds.apache.org/job/Camel.website/job/PR-228/Preview/blog/).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] AemieJ commented on a change in pull request #228:
CAMEL-14581: Improve the accessibility factor under the blog section
Posted by GitBox <gi...@apache.org>.
AemieJ commented on a change in pull request #228: CAMEL-14581: Improve the accessibility factor under the blog section
URL: https://github.com/apache/camel-website/pull/228#discussion_r400287489
##########
File path: antora-ui-camel/src/css/vars.css
##########
@@ -18,7 +19,10 @@
--color-black: #000;
--color-asf-dark-blue: #303284;
--color-asf-moderate-blue: #585ac2;
+ --color-bistre: #41250c;
--color-camel-orange: #ed8225;
+ --color-camel-vivid-orange: #e97826;
Review comment:
Alright, it gives a higher color contrast, I will observe and change it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#228: CAMEL-14581: Improve the accessibility factor under the blog section
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #228: CAMEL-14581: Improve the accessibility factor under the blog section
URL: https://github.com/apache/camel-website/pull/228#discussion_r400218847
##########
File path: antora-ui-camel/src/css/vars.css
##########
@@ -18,7 +19,10 @@
--color-black: #000;
--color-asf-dark-blue: #303284;
--color-asf-moderate-blue: #585ac2;
+ --color-bistre: #41250c;
--color-camel-orange: #ed8225;
+ --color-camel-vivid-orange: #e97826;
Review comment:
I'd replace Camel orange with this color and make it consistent across
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] AemieJ commented on issue #228: CAMEL-14581:
Improve the accessibility factor under the blog section
Posted by GitBox <gi...@apache.org>.
AemieJ commented on issue #228: CAMEL-14581: Improve the accessibility factor under the blog section
URL: https://github.com/apache/camel-website/pull/228#issuecomment-602589447
> We need to use variables, it will be very difficult for us to maintain the CSS otherwise.
Alright, I will make those changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #228: CAMEL-14581:
Improve the accessibility factor under the blog section
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #228: CAMEL-14581: Improve the accessibility factor under the blog section
URL: https://github.com/apache/camel-website/pull/228#issuecomment-604951884
@AemieJ with that are we okay to close this or do you wish to make changes on this branch/pull request?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services