[GitHub] [helix] pkuwm commented on pull request #1650: Improve auto enter maintenance mode

[GitBox <gi...@apache.org>]

pkuwm commented on pull request #1650:
URL: https://github.com/apache/helix/pull/1650#issuecomment-783853573


   Thanks, @jiajunwang @alirezazamani @dasahcc, for the review and approvals.
   
   This PR is ready to be merged, approved @jiajunwang @alirezazamani 
   
   Assume enter M mode threshold is 5. Now 20 nodes are down at the same time, the running pipeline creates the maintenance znode. Instead of using the maintenance rebalancer immediately, this running pipeline still continues with the normal rebalancer, which moves new partitions on the online instances.
   
   This commit improves auto enter maintenance mode logic by enabling maintenance mode in the data cache, so the best possible mapping can be computed by the maintenance rebalancer immediately for the first pipeline.
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org