You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/02/03 20:36:14 UTC

[GitHub] [iceberg] aokolnychyi opened a new pull request #2205: Spark: Add more tests with multiple subqueries in DELETE

aokolnychyi opened a new pull request #2205:
URL: https://github.com/apache/iceberg/pull/2205


   This PR adds more tests with multiple subqueries in DELETE. Previously, some tests defined two views but used only one.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] aokolnychyi commented on pull request #2205: Spark: Add more tests with multiple subqueries in DELETE

Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on pull request #2205:
URL: https://github.com/apache/iceberg/pull/2205#issuecomment-772828920


   The test failures in `TestFlinkTableSink ` seem unrelated to this PR.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] aokolnychyi commented on pull request #2205: Spark: Add more tests with multiple subqueries in DELETE

Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on pull request #2205:
URL: https://github.com/apache/iceberg/pull/2205#issuecomment-772877392


   Thanks for reviewing, @rdblue @dilipbiswal!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] aokolnychyi commented on pull request #2205: Spark: Add more tests with multiple subqueries in DELETE

Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on pull request #2205:
URL: https://github.com/apache/iceberg/pull/2205#issuecomment-772805591


   cc @rdblue @dilipbiswal @mehtaashish23 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] rdblue commented on pull request #2205: Spark: Add more tests with multiple subqueries in DELETE

Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #2205:
URL: https://github.com/apache/iceberg/pull/2205#issuecomment-772831625


   You should be able to re-run the checks from the details page. I think anyone with commit privileges should be able to.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] dilipbiswal commented on pull request #2205: Spark: Add more tests with multiple subqueries in DELETE

Posted by GitBox <gi...@apache.org>.
dilipbiswal commented on pull request #2205:
URL: https://github.com/apache/iceberg/pull/2205#issuecomment-772844790


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] aokolnychyi merged pull request #2205: Spark: Add more tests with multiple subqueries in DELETE

Posted by GitBox <gi...@apache.org>.
aokolnychyi merged pull request #2205:
URL: https://github.com/apache/iceberg/pull/2205


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org