You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/11/30 20:01:02 UTC

[jira] [Commented] (BEAM-1000) Add non blocking cancel() and waitUntilFinish() for Spark batch application

    [ https://issues.apache.org/jira/browse/BEAM-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15709611#comment-15709611 ] 

ASF GitHub Bot commented on BEAM-1000:
--------------------------------------

GitHub user staslev opened a pull request:

    https://github.com/apache/incubator-beam/pull/1466

    Aligned the Spark batch and streaming pipelines to adhere to waitUntilFinish and cancel

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    Introduced SparkPipelineResult that should be able to better support PipelineResult semantics, such as waitUntilFinish and cancel. 
    
    Also relates to BEAM-1000,  BEAM-595 and BEAM-1050 as well as to #1438.
    
    R: @amitsela 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/staslev/incubator-beam spark-pipeline-result

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1466.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1466
    
----
commit 63ba243c54dc50567fe73f88f2e8d17466121987
Author: Stas Levin <st...@gmail.com>
Date:   2016-11-28T09:11:10Z

    Added a SparkPipelineResult class to address PipelineResult#waitUntilFinish() and SparkRunner#run() semantics, also relates to BEAM-1000,  BEAM-595 and BEAM-1050.

----


> Add non blocking cancel() and waitUntilFinish() for Spark batch application
> ---------------------------------------------------------------------------
>
>                 Key: BEAM-1000
>                 URL: https://issues.apache.org/jira/browse/BEAM-1000
>             Project: Beam
>          Issue Type: Sub-task
>          Components: runner-spark
>            Reporter: Kobi Salant
>
> Spark batch submit by nature is blocking. 
> To enable cancel and waitForFinish we will need to run it in a different thread/future and return a context which communicates with it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)