You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Max Starets (JIRA)" <de...@myfaces.apache.org> on 2008/02/06 21:57:08 UTC

[jira] Created: (TRINIDAD-940) GenericConverterFactory.getInstance() should not be storing factory instance as a static variable

GenericConverterFactory.getInstance() should not be storing factory instance as a static variable
-------------------------------------------------------------------------------------------------

                 Key: TRINIDAD-940
                 URL: https://issues.apache.org/jira/browse/TRINIDAD-940
             Project: MyFaces Trinidad
          Issue Type: Bug
    Affects Versions: 1.2.5-core
            Reporter: Max Starets
             Fix For: 1.2.6-core


This is a follow-up to the problem that we discovered during fixing TRINIDAD-858.
GenericConverterFactory should not be static because different applications may be registering different
GenericConverters. Instead, it should be stored on the Application map.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TRINIDAD-940) GenericConverterFactory.getInstance() should not be storing factory instance as a static variable

Posted by "Max Starets (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TRINIDAD-940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Max Starets updated TRINIDAD-940:
---------------------------------

    Status: Patch Available  (was: Open)

> GenericConverterFactory.getInstance() should not be storing factory instance as a static variable
> -------------------------------------------------------------------------------------------------
>
>                 Key: TRINIDAD-940
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-940
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>    Affects Versions: 1.2.5-core
>            Reporter: Max Starets
>             Fix For: 1.2.6-core
>
>         Attachments: TRINIDAD-940.patch
>
>
> This is a follow-up to the problem that we discovered during fixing TRINIDAD-858.
> GenericConverterFactory should not be static because different applications may be registering different
> GenericConverters. Instead, it should be stored on the Application map.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TRINIDAD-940) GenericConverterFactory.getInstance() should not be storing factory instance as a static variable

Posted by "Max Starets (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TRINIDAD-940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566334#action_12566334 ] 

Max Starets commented on TRINIDAD-940:
--------------------------------------

Changes in the patch were reviewed by Blake and Gabrielle when I was working on TRINIDAD-858. I was just waiting for the new version of Trinidad to be consumed by Oracle, so that we could start using getInstance() version taking ExternalContext. With that change, we can now switch to using ApplicationMap to store factory instance,

> GenericConverterFactory.getInstance() should not be storing factory instance as a static variable
> -------------------------------------------------------------------------------------------------
>
>                 Key: TRINIDAD-940
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-940
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>    Affects Versions: 1.2.5-core
>            Reporter: Max Starets
>             Fix For: 1.2.6-core
>
>         Attachments: TRINIDAD-940.patch
>
>
> This is a follow-up to the problem that we discovered during fixing TRINIDAD-858.
> GenericConverterFactory should not be static because different applications may be registering different
> GenericConverters. Instead, it should be stored on the Application map.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.