You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2015/08/18 14:08:34 UTC
svn commit: r1696407 -
/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/
Author: sebb
Date: Tue Aug 18 12:08:33 2015
New Revision: 1696407
URL: http://svn.apache.org/r1696407
Log:
Add @since markers
Modified:
commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Attribute.java
commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ClassFormatException.java
commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantCP.java
commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantUtf8.java
commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/DescendingVisitor.java
commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/JavaClass.java
commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/LocalVariableTypeTable.java
commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Method.java
commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Signature.java
commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/StackMapEntry.java
commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/StackMapType.java
commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/UnknownAttributeReader.java
commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Utility.java
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Attribute.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Attribute.java?rev=1696407&r1=1696406&r2=1696407&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Attribute.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Attribute.java Tue Aug 18 12:08:33 2015
@@ -150,6 +150,7 @@ public abstract class Attribute implemen
* @return Attribute
* @throws IOException
* @throws ClassFormatException
+ * @since 6.0
*/
public static Attribute readAttribute(DataInput file, ConstantPool constant_pool)
throws IOException, ClassFormatException
@@ -235,6 +236,7 @@ public abstract class Attribute implemen
/**
* @return Name of attribute
+ * @since 6.0
*/
public String getName()
{
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ClassFormatException.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ClassFormatException.java?rev=1696407&r1=1696406&r2=1696407&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ClassFormatException.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ClassFormatException.java Tue Aug 18 12:08:33 2015
@@ -37,7 +37,11 @@ public class ClassFormatException extend
super(s);
}
- public ClassFormatException(String s, Throwable initCause) {
- super(s, initCause);
+ /**
+ * {@inheritDoc}
+ * @since 6.0
+ */
+ public ClassFormatException(String message, Throwable cause) {
+ super(message, cause);
}
}
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantCP.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantCP.java?rev=1696407&r1=1696406&r2=1696407&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantCP.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantCP.java Tue Aug 18 12:08:33 2015
@@ -103,6 +103,7 @@ public abstract class ConstantCP extends
*
* Note that this method is a functional duplicate of getClassIndex
* for use by ConstantInvokeDynamic.
+ * @since 6.0
*/
public final int getBootstrapMethodAttrIndex() {
return class_index; // AKA bootstrap_method_attr_index
@@ -122,6 +123,7 @@ public abstract class ConstantCP extends
*
* Note that this method is a functional duplicate of setClassIndex
* for use by ConstantInvokeDynamic.
+ * @since 6.0
*/
public final void setBootstrapMethodAttrIndex(int bootstrap_method_attr_index) {
this.class_index = bootstrap_method_attr_index;
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantUtf8.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantUtf8.java?rev=1696407&r1=1696406&r2=1696407&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantUtf8.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantUtf8.java Tue Aug 18 12:08:33 2015
@@ -88,6 +88,9 @@ public final class ConstantUtf8 extends
}
}
+ /**
+ * @since 6.0
+ */
public static ConstantUtf8 getCachedInstance(String s) {
if (s.length() > MAX_CACHED_SIZE) {
skipped++;
@@ -106,10 +109,16 @@ public final class ConstantUtf8 extends
}
}
+ /**
+ * @since 6.0
+ */
public static ConstantUtf8 getInstance(String s) {
return new ConstantUtf8(s);
}
+ /**
+ * @since 6.0
+ */
public static ConstantUtf8 getInstance (DataInput input) throws IOException {
return getInstance(input.readUTF());
}
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/DescendingVisitor.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/DescendingVisitor.java?rev=1696407&r1=1696406&r2=1696407&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/DescendingVisitor.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/DescendingVisitor.java Tue Aug 18 12:08:33 2015
@@ -106,6 +106,9 @@ public class DescendingVisitor implement
stack.pop();
}
+ /**
+ * @since 6.0
+ */
@Override
public void visitAnnotation(Annotations annotation)
{
@@ -118,6 +121,9 @@ public class DescendingVisitor implement
stack.pop();
}
+ /**
+ * @since 6.0
+ */
@Override
public void visitAnnotationEntry(AnnotationEntry annotationEntry)
{
@@ -242,6 +248,9 @@ public class DescendingVisitor implement
stack.pop();
}
+ /**
+ * @since 6.0
+ */
@Override
public void visitStackMapTable(StackMapTable table)
{
@@ -254,6 +263,9 @@ public class DescendingVisitor implement
stack.pop();
}
+ /**
+ * @since 6.0
+ */
@Override
public void visitStackMapTableEntry(StackMapTableEntry var)
{
@@ -335,6 +347,9 @@ public class DescendingVisitor implement
stack.pop();
}
+ /**
+ * @since 6.0
+ */
@Override
public void visitConstantInvokeDynamic(
ConstantInvokeDynamic constant)
@@ -404,6 +419,9 @@ public class DescendingVisitor implement
stack.pop();
}
+ /**
+ * @since 6.0
+ */
@Override
public void visitBootstrapMethods(BootstrapMethods bm)
{
@@ -457,6 +475,9 @@ public class DescendingVisitor implement
stack.pop();
}
+ /**
+ * @since 6.0
+ */
@Override
public void visitAnnotationDefault(AnnotationDefault obj)
{
@@ -465,6 +486,9 @@ public class DescendingVisitor implement
stack.pop();
}
+ /**
+ * @since 6.0
+ */
@Override
public void visitEnclosingMethod(EnclosingMethod obj)
{
@@ -473,6 +497,9 @@ public class DescendingVisitor implement
stack.pop();
}
+ /**
+ * @since 6.0
+ */
@Override
public void visitLocalVariableTypeTable(LocalVariableTypeTable obj)
{
@@ -481,6 +508,9 @@ public class DescendingVisitor implement
stack.pop();
}
+ /**
+ * @since 6.0
+ */
@Override
public void visitParameterAnnotation(ParameterAnnotations obj)
{
@@ -489,6 +519,9 @@ public class DescendingVisitor implement
stack.pop();
}
+ /**
+ * @since 6.0
+ */
@Override
public void visitMethodParameters(MethodParameters obj)
{
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/JavaClass.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/JavaClass.java?rev=1696407&r1=1696406&r2=1696407&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/JavaClass.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/JavaClass.java Tue Aug 18 12:08:33 2015
@@ -338,6 +338,7 @@ public class JavaClass extends AccessFla
/**
* @return Annotations on the class
+ * @since 6.0
*/
public AnnotationEntry[] getAnnotationEntries() {
if (annotations == null) {
@@ -701,11 +702,17 @@ public class JavaClass extends AccessFla
return (super.getAccessFlags() & Constants.ACC_INTERFACE) == 0;
}
+ /**
+ * @since 6.0
+ */
public final boolean isAnonymous() {
computeNestedTypeStatus();
return this.isAnonymous;
}
+ /**
+ * @since 6.0
+ */
public final boolean isNested() {
computeNestedTypeStatus();
return this.isNested;
@@ -713,8 +720,8 @@ public class JavaClass extends AccessFla
private void computeNestedTypeStatus() {
if (computedNestedTypeStatus) {
- return;
- }
+ return;
+ }
for (Attribute attribute : this.attributes) {
if (attribute instanceof InnerClasses) {
InnerClass[] innerClasses = ((InnerClasses) attribute).getInnerClasses();
@@ -909,6 +916,7 @@ public class JavaClass extends AccessFla
/**
* Return the natural ordering of two JavaClasses.
* This ordering is based on the class name
+ * @since 6.0
*/
@Override
public int compareTo( JavaClass obj ) {
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/LocalVariableTypeTable.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/LocalVariableTypeTable.java?rev=1696407&r1=1696406&r2=1696407&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/LocalVariableTypeTable.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/LocalVariableTypeTable.java Tue Aug 18 12:08:33 2015
@@ -52,7 +52,7 @@ import org.apache.commons.bcel6.Constant
// J5TODO: Needs some testing !
/**
- * since 6.0
+ * @since 6.0
*/
public class LocalVariableTypeTable extends Attribute {
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Method.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Method.java?rev=1696407&r1=1696406&r2=1696407&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Method.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Method.java Tue Aug 18 12:08:33 2015
@@ -263,6 +263,7 @@ public final class Method extends FieldO
/**
* @return Annotations on the parameters of a method
+ * @since 6.0
*/
public ParameterAnnotationEntry[] getParameterAnnotationEntries() {
if (parameterAnnotationEntries == null) {
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Signature.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Signature.java?rev=1696407&r1=1696406&r2=1696407&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Signature.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Signature.java Tue Aug 18 12:08:33 2015
@@ -239,11 +239,13 @@ public final class Signature extends Att
}
+ // @since 6.0 is no longer final
public static boolean isFormalParameterList( String s ) {
return s.startsWith("<") && (s.indexOf(':') > 0);
}
+ // @since 6.0 is no longer final
public static boolean isActualParameterList( String s ) {
return s.startsWith("L") && s.endsWith(">;");
}
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/StackMapEntry.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/StackMapEntry.java?rev=1696407&r1=1696406&r2=1696407&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/StackMapEntry.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/StackMapEntry.java Tue Aug 18 12:08:33 2015
@@ -31,7 +31,9 @@ import java.io.Serializable;
* @see StackMap
* @see StackMapType
*/
-public final class StackMapEntry implements Cloneable, Serializable {
+public final class StackMapEntry implements Cloneable
+ ,Serializable /* since 6.0 */
+{
private static final long serialVersionUID = 1L;
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/StackMapType.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/StackMapType.java?rev=1696407&r1=1696406&r2=1696407&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/StackMapType.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/StackMapType.java Tue Aug 18 12:08:33 2015
@@ -33,7 +33,8 @@ import org.apache.commons.bcel6.Constant
* @see StackMap
* @see Constants
*/
-public final class StackMapType implements Cloneable, Serializable {
+public final class StackMapType implements Cloneable
+ ,Serializable /* since 6.0 */ {
private static final long serialVersionUID = 1L;
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/UnknownAttributeReader.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/UnknownAttributeReader.java?rev=1696407&r1=1696406&r2=1696407&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/UnknownAttributeReader.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/UnknownAttributeReader.java Tue Aug 18 12:08:33 2015
@@ -24,6 +24,7 @@ package org.apache.commons.bcel6.classfi
*
* @see Attribute
* @version $Id$
+ * @since 6.0
*/
public interface UnknownAttributeReader {
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Utility.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Utility.java?rev=1696407&r1=1696406&r2=1696407&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Utility.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Utility.java Tue Aug 18 12:08:33 2015
@@ -42,6 +42,7 @@ import org.apache.commons.bcel6.util.Byt
*
* @version $Id$
*/
+// @since 6.0 methods are no longer final
public abstract class Utility {
private static int unwrap( ThreadLocal<Integer> tl ) {