Re: [PR] SOLR-17806: Convert CoreContainer metrics to OTEL [solr]

["mlbiscoc (via GitHub)" <gi...@apache.org>]

mlbiscoc commented on code in PR #3509:
URL: https://github.com/apache/solr/pull/3509#discussion_r2316165519


##########
solr/solrj-zookeeper/src/java/org/apache/solr/client/solrj/impl/NodeValueFetcher.java:
##########
@@ -38,6 +38,8 @@
  * This class is responsible for fetching metrics and other attributes from a given node in Solr
  * cluster. This is a helper class that is used by {@link SolrClientNodeStateProvider}
  */
+// NOCOMMIT: Need to removed hardcoded references to Dropwizard metrics for OTEL conversion, and
+// probably change enum structure to be more compatible with OTEL naming
 public class NodeValueFetcher {

Review Comment:
   Will need to look into what this does and how it can be migrated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org