[jira] [Commented] (NIFI-1812) Add nifi-env script

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-1812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15271064#comment-15271064 ] 

ASF GitHub Bot commented on NIFI-1812:
--------------------------------------

Github user alopresto commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/386#discussion_r62082835
  
    --- Diff: nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/RunNiFi.java ---
    @@ -324,27 +324,46 @@ private void registerNotificationServices(final NotificationServiceManager manag
             defaultLogger.info("Registered {} Notification Services for Notification Type {}", registered, type);
         }
     
    -    File getStatusFile() {
    +    File getStatusFile() throws IOException{
    --- End diff --
    
    Any reason this is default scoped but the overloaded method is public?


> Add nifi-env script 
> --------------------
>
>                 Key: NIFI-1812
>                 URL: https://issues.apache.org/jira/browse/NIFI-1812
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Yolanda M. Davis
>             Fix For: 1.0.0
>
>
> The nifi-env script should be created for use by nifi startup, status and shutdown scripts to set env variables like JAVA_HOME, location of log dir, location of pid dir etc. This makes it easier to manage these locations in a single script. For example currently the path to java is set in bootstrap.conf however if your system does not have JAVA_HOME set or java in path the nifi start command fails (so the user has to explicitly set JAVA_HOME or PATH before invoking nifi start). 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)