You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@camel.apache.org by "Claus Ibsen (JIRA)" <ji...@apache.org> on 2012/08/13 13:07:38 UTC
[jira] [Created] (CAMEL-5501) @XPath annotation should ensure
cleanup after evaluation
Claus Ibsen created CAMEL-5501:
----------------------------------
Summary: @XPath annotation should ensure cleanup after evaluation
Key: CAMEL-5501
URL: https://issues.apache.org/jira/browse/CAMEL-5501
Project: Camel
Issue Type: Bug
Components: camel-core
Affects Versions: 2.10.0, 2.9.2
Reporter: Claus Ibsen
Assignee: Claus Ibsen
Priority: Minor
Fix For: 2.9.3, 2.10.1, 2.11.0
See CAMEL-3813
Look into the @XPath bean parameter binding and ensure its resources is cleaned up after usage.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-5501) @XPath annotation should ensure
cleanup after evaluation
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433127#comment-13433127 ]
Claus Ibsen commented on CAMEL-5501:
------------------------------------
Okay i have reproduce an issue when using ognl expressions on beans that use @XPath annoations
> @XPath annotation should ensure cleanup after evaluation
> --------------------------------------------------------
>
> Key: CAMEL-5501
> URL: https://issues.apache.org/jira/browse/CAMEL-5501
> Project: Camel
> Issue Type: Bug
> Components: camel-core
> Affects Versions: 2.9.2, 2.10.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 2.9.3, 2.10.1, 2.11.0
>
>
> See CAMEL-3813
> Look into the @XPath bean parameter binding and ensure its resources is cleaned up after usage.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-5501) @XPath annotation should ensure
cleanup after evaluation
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433249#comment-13433249 ]
Claus Ibsen commented on CAMEL-5501:
------------------------------------
On a very crude test on my laptop by sending 33333 messages in org.apache.camel.language.XPathRouteConcurrentBigTest, i get the test to go from 90 sec to 60 sec on my laptop. Notice this is a crude test by running it locally 5 times in a row, and taking the avg. time.
> @XPath annotation should ensure cleanup after evaluation
> --------------------------------------------------------
>
> Key: CAMEL-5501
> URL: https://issues.apache.org/jira/browse/CAMEL-5501
> Project: Camel
> Issue Type: Bug
> Components: camel-core
> Affects Versions: 2.9.2, 2.10.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 2.9.3, 2.10.1, 2.11.0
>
>
> See CAMEL-3813
> Look into the @XPath bean parameter binding and ensure its resources is cleaned up after usage.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-5501) @XPath annotation should ensure
cleanup after evaluation
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433155#comment-13433155 ]
Claus Ibsen commented on CAMEL-5501:
------------------------------------
Its CAMEL-1930 that introduced improved concurrency in xpath builder. I think we can improved that a bit to only use a thread local for the exchange. The variable resolver do not really need to be thread local as well. But just refer to the exchange as it does today. And then we can remove the thread local on each evaluation, instead of keeping it set on the thread.
This should more nicely cleanup the resources in all situations also when using @XPath annotations in ognl method calls and whatnot.
> @XPath annotation should ensure cleanup after evaluation
> --------------------------------------------------------
>
> Key: CAMEL-5501
> URL: https://issues.apache.org/jira/browse/CAMEL-5501
> Project: Camel
> Issue Type: Bug
> Components: camel-core
> Affects Versions: 2.9.2, 2.10.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 2.9.3, 2.10.1, 2.11.0
>
>
> See CAMEL-3813
> Look into the @XPath bean parameter binding and ensure its resources is cleaned up after usage.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CAMEL-5501) @XPath annotation should ensure
cleanup after evaluation
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen resolved CAMEL-5501.
--------------------------------
Resolution: Fixed
This also optimized xpath builder under load as there is less thread locals, and no on completion etc. And makes it for better GC as no thread locals is kept for a longer time.
> @XPath annotation should ensure cleanup after evaluation
> --------------------------------------------------------
>
> Key: CAMEL-5501
> URL: https://issues.apache.org/jira/browse/CAMEL-5501
> Project: Camel
> Issue Type: Bug
> Components: camel-core
> Affects Versions: 2.9.2, 2.10.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 2.9.3, 2.10.1, 2.11.0
>
>
> See CAMEL-3813
> Look into the @XPath bean parameter binding and ensure its resources is cleaned up after usage.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira