You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "David Smiley (JIRA)" <ji...@apache.org> on 2014/07/04 06:42:34 UTC
[jira] [Updated] (LUCENE-5714) Improve tests for BBoxStrategy then
port to 4x.
[ https://issues.apache.org/jira/browse/LUCENE-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Smiley updated LUCENE-5714:
---------------------------------
Attachment: LUCENE-5714_Enhance_BBoxStrategy.patch
Latest patch:
* BBoxSimilarity is gone; instead BBoxSimilarityValueSource is abstract (just one impl though)
* Removed DistanceSimilarity as it's obsoleted by the generic DistanceToShapeValueSource introduced a couple months ago
* AreaSimilarity renamed to BBoxOverlapRatioValueSource as it's a more meaningful name
* BBoxOverlapRatioValueSource has a new minSideLength option that is applied to sides of the query, target, and intersection boxes. It's an optional way to handle point queries, which without this would basically match everything with the same score since there is no intersection area.
* Added generic ShapeAreaValueSource (with geoArea boolean option) that basically just calls shape.getArea(). This is a good way of handling sorting the results of a point query for indexed rects.
* setPrecisionType is gone; instead I'm trying a new scheme in which you get and set a FieldType. See LUCENE-5802. Use of DocValues is configurable and enabled by default.
I think it's probably ready to be committed now.
> Improve tests for BBoxStrategy then port to 4x.
> -----------------------------------------------
>
> Key: LUCENE-5714
> URL: https://issues.apache.org/jira/browse/LUCENE-5714
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/spatial
> Reporter: David Smiley
> Assignee: David Smiley
> Fix For: 4.10
>
> Attachments: LUCENE-5714_Enhance_BBoxStrategy.patch, LUCENE-5714__Enhance_BBoxStrategy__more_tests,_fix_dateline_bugs,_new_AreaSimilarity_algor.patch
>
>
> BBoxStrategy needs better tests before I'm comfortable seeing it in 4x. Specifically it should use random rectangles based validation (ones that may cross the dateline), akin to the other tests. And I think I see an equals/hashcode bug to be fixed in there too.
> One particular thing I'd like to see added is how to handle a zero-area case for AreaSimilarity. I think an additional feature in which you declare a minimum % area (relative to the query shape) would be good.
> It should be possible for the user to combine rectangle center-point to query shape center-point distance sorting as well. I think it is but I need to make sure it's possible without _having_ to index a separate center point field.
> Another possibility (probably not to be addressed here) is a minimum ratio between width/height, perhaps 10%. A long but nearly no height line should not be massively disadvantaged relevancy-wise to an equivalently long diagonal road that has a square bbox.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org