You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/08/01 15:37:00 UTC
[jira] [Commented] (FELIX-5669) Registering a PersistenceManager
causes duplicate caches
[ https://issues.apache.org/jira/browse/FELIX-5669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16109105#comment-16109105 ]
ASF GitHub Bot commented on FELIX-5669:
---------------------------------------
GitHub user brjeter opened a pull request:
https://github.com/apache/felix/pull/115
FELIX-5669 Fixing bug in ConfigurationManager that duplicates PersistenceManager caches
The `ConfigurationManager` duplicates `CachingPersistenceManagerProxy`s when `getPersistenceManagers()` is called after registering a new `PersistenceManager`. This fixes it to use the previous `CachingPersistenceManagerProxy` if one exists.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/brjeter/felix FELIX-5669
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/felix/pull/115.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #115
----
commit ab6655478dd1390a8399d258bc4eccf94ad991d4
Author: Brandan Jeter <br...@gmail.com>
Date: 2017-08-01T15:32:47Z
FELIX-5669 Fixing bug in ConfigurationManager that duplicates PersistenceManager caches
----
> Registering a PersistenceManager causes duplicate caches
> --------------------------------------------------------
>
> Key: FELIX-5669
> URL: https://issues.apache.org/jira/browse/FELIX-5669
> Project: Felix
> Issue Type: Bug
> Reporter: Brandan Jeter
>
> When registering a PersistenceManager, the next call to a method in ConfigurationManager will call getPersistenceManagers(). Instead of preserving the existing CachingPersistenceManagerProxy that wraps the default FilePersistenceManager, ConfigurationManager creates a brand new one. But previous Configuration objects still have reference to the old CachingPersistenceManagerProxy, so when one of them gets deleted/updated it does not get deleted/updated in the ConfigurationManager's reference.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)