You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/09/23 18:58:24 UTC
[GitHub] [pinot] klsince commented on a diff in pull request #9457: track progress from within segment processor framework
klsince commented on code in PR #9457:
URL: https://github.com/apache/pinot/pull/9457#discussion_r978982402
##########
pinot-minion/src/main/java/org/apache/pinot/minion/taskfactory/TaskFactoryRegistry.java:
##########
@@ -127,17 +127,17 @@ private TaskResult runInternal() {
_eventObserver.notifyTaskCancelled(pinotTaskConfig);
_minionMetrics.addMeteredTableValue(taskType, MinionMeter.NUMBER_TASKS_CANCELLED, 1L);
LOGGER.info("Task: {} got cancelled", _taskConfig.getId(), e);
- return new TaskResult(TaskResult.Status.CANCELED, e.toString());
+ return new TaskResult(TaskResult.Status.CANCELED, StringUtil.getStackTraceAsString(e));
} catch (FatalException e) {
_eventObserver.notifyTaskError(pinotTaskConfig, e);
_minionMetrics.addMeteredTableValue(taskType, MinionMeter.NUMBER_TASKS_FATAL_FAILED, 1L);
LOGGER.error("Caught fatal exception while executing task: {}", _taskConfig.getId(), e);
- return new TaskResult(TaskResult.Status.FATAL_FAILED, e.toString());
+ return new TaskResult(TaskResult.Status.FATAL_FAILED, StringUtil.getStackTraceAsString(e));
} catch (Exception e) {
_eventObserver.notifyTaskError(pinotTaskConfig, e);
_minionMetrics.addMeteredTableValue(taskType, MinionMeter.NUMBER_TASKS_FAILED, 1L);
LOGGER.error("Caught exception while executing task: {}", _taskConfig.getId(), e);
- return new TaskResult(TaskResult.Status.FAILED, e.toString());
+ return new TaskResult(TaskResult.Status.FAILED, StringUtil.getStackTraceAsString(e));
Review Comment:
e.toString() like e.getMessage() just returns the error msg (basically the first line of the stack trace).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org