[GitHub] [lucene] mocobeta commented on a change in pull request #473: LUCENE-10260: Luke's about window no longer shows version number

[GitBox <gi...@apache.org>]

mocobeta commented on a change in pull request #473:
URL: https://github.com/apache/lucene/pull/473#discussion_r757190187



##########
File path: lucene/luke/src/java/org/apache/lucene/luke/app/desktop/components/dialog/menubar/AboutDialogFactory.java
##########
@@ -173,15 +172,15 @@ private JPanel footer() {
   }
 
   private static final String LUCENE_IMPLEMENTATION_VERSION =
-      LucenePackage.get().getImplementationVersion();
+      Version.getPackageImplementationVersion();

Review comment:
       (Question) If Luke runs on module mode and `MANIFEST.MF` does not exist in lucene-core jar for some reason (on development?), Luke fails to start...?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org