You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by ro...@apache.org on 2017/11/10 17:35:40 UTC
[5/6] lucene-solr:branch_7x: LUCENE-8042: Fix precommit and CHANGES
LUCENE-8042: Fix precommit and CHANGES
Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/317c9f35
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/317c9f35
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/317c9f35
Branch: refs/heads/branch_7x
Commit: 317c9f359f3779725324fdb546fbb2ebe7fcf54c
Parents: 6e4f9a6
Author: Alan Woodward <ro...@apache.org>
Authored: Fri Nov 10 17:10:13 2017 +0000
Committer: Alan Woodward <ro...@apache.org>
Committed: Fri Nov 10 17:10:13 2017 +0000
----------------------------------------------------------------------
lucene/CHANGES.txt | 6 ++++--
.../lucene/search/suggest/document/CompletionWeight.java | 5 +++++
2 files changed, 9 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/317c9f35/lucene/CHANGES.txt
----------------------------------------------------------------------
diff --git a/lucene/CHANGES.txt b/lucene/CHANGES.txt
index a45b492..3ffa969 100644
--- a/lucene/CHANGES.txt
+++ b/lucene/CHANGES.txt
@@ -11,8 +11,10 @@ API Changes
allows distance calculations, especially for paths, to take into account an
"excursion" to include the specified point.
-* LUCENE-8017: Weight now exposes a getCacheHelper() method to help query caches
- determine whether or not a query can be cached. (Alan Woodward)
+* LUCENE-8017, LUCENE-8042: Weight, DoubleValuesSource and related objects
+ now implement a SegmentCacheable interface, with a single method
+ isCacheable(LeafReaderContext) determining whether or not the object may
+ be cached against a LeafReader. (Alan Woodward, Robert Muir)
* LUCENE-8038: Payload factors for scoring in PayloadScoreQuery are now
calculated by a PayloadDecoder, instead of delegating to the Similarity.
http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/317c9f35/lucene/suggest/src/java/org/apache/lucene/search/suggest/document/CompletionWeight.java
----------------------------------------------------------------------
diff --git a/lucene/suggest/src/java/org/apache/lucene/search/suggest/document/CompletionWeight.java b/lucene/suggest/src/java/org/apache/lucene/search/suggest/document/CompletionWeight.java
index 35ab424..1f97d55 100644
--- a/lucene/suggest/src/java/org/apache/lucene/search/suggest/document/CompletionWeight.java
+++ b/lucene/suggest/src/java/org/apache/lucene/search/suggest/document/CompletionWeight.java
@@ -132,6 +132,11 @@ public class CompletionWeight extends Weight {
throw new UnsupportedOperationException();
}
+ /**
+ * This object can be cached
+ *
+ * @see org.apache.lucene.search.SegmentCacheable#isCacheable(LeafReaderContext)
+ */
@Override
public boolean isCacheable(LeafReaderContext ctx) {
return true;