[GitHub] [inlong] featzhang commented on a diff in pull request #7272: [INLONG-7271][Manager] Support comma separation for primary key and partition key of Hudi table

["featzhang (via GitHub)" <gi...@apache.org>]

featzhang commented on code in PR #7272:
URL: https://github.com/apache/inlong/pull/7272#discussion_r1089860212


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/sink/hudi/HudiSinkOperator.java:
##########
@@ -77,20 +82,22 @@ protected void setTargetEntity(SinkRequest request, StreamSinkEntity targetEntit
 
         String partitionKey = sinkRequest.getPartitionKey();
         String primaryKey = sinkRequest.getPrimaryKey();
-        boolean primaryKeyExist = StringUtils.isNotEmpty(partitionKey);
-        boolean partitionKeyExist = StringUtils.isNotEmpty(primaryKey);
+        boolean primaryKeyExist = StringUtils.isNotBlank(partitionKey);

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org