You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by lollipop <lo...@apache.org> on 2017/01/03 06:57:35 UTC
Re: [DISCUSS] Getting rid of MixAll class
Hi，Roman:
It seems cool to combine the helper methods from MixAll and UtilAll into
one main Class and extract the constants to a new Class named like
'XXXConst'.
Could you please do the refactor work and submit a PR, and we will review
it later.
Best Regards,
Lollipop
On Fri, Dec 30, 2016 at 12:36 PM, Roman Shtykh <rs...@yahoo.com.invalid>
wrote:
> Folks,
>
> MixAll class in 'common' module looks really like a mix of many things :)
> It contains string constants and helper methods, while there's another
> class with helper methods (UtilAll) in the same module, and other classes
> in 'common' containing string constants.
>
> I propose to move all constants to a new class RocketMQProperties and all
> helper methods to UtilAll. Please see [1]
> Thoughts?
>
> [1] https://issues.apache.org/jira/browse/ROCKETMQ-4
>
> Roman Shtykh
>
Re: [DISCUSS] Getting rid of MixAll class
Posted by Roman Shtykh <rs...@yahoo.com.INVALID>.
Hi Lollipop,
Thanks! Great to know your opinion, since this class is used throughout most of the code base.
Regards,
Roman Shtykh
On Tuesday, January 3, 2017 3:57 PM, lollipop <lo...@apache.org> wrote:
Hi，Roman:
It seems cool to combine the helper methods from MixAll and UtilAll into
one main Class and extract the constants to a new Class named like
'XXXConst'.
Could you please do the refactor work and submit a PR, and we will review
it later.
Best Regards,
Lollipop
On Fri, Dec 30, 2016 at 12:36 PM, Roman Shtykh <rs...@yahoo.com.invalid>
wrote:
> Folks,
>
> MixAll class in 'common' module looks really like a mix of many things :)
> It contains string constants and helper methods, while there's another
> class with helper methods (UtilAll) in the same module, and other classes
> in 'common' containing string constants.
>
> I propose to move all constants to a new class RocketMQProperties and all
> helper methods to UtilAll. Please see [1]
> Thoughts?
>
> [1] https://issues.apache.org/jira/browse/ROCKETMQ-4
>
> Roman Shtykh
>