You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Mat Mannion (JIRA)" <ji...@apache.org> on 2010/05/20 15:44:55 UTC

[jira] Created: (SHINDIG-1337) MutableContent throws NPE on getContentBytes() after documentChanged()

MutableContent throws NPE on getContentBytes() after documentChanged()
----------------------------------------------------------------------

                 Key: SHINDIG-1337
                 URL: https://issues.apache.org/jira/browse/SHINDIG-1337
             Project: Shindig
          Issue Type: Bug
          Components: Java
    Affects Versions: 2.0.0-RC1
            Reporter: Mat Mannion


There is an error in MutableContent.getRawContentBytes() that is stopping MutableContent.getContentBytes() being used when the document has been changed, since the result of HTML serialization is not assigned back to the contentBytes property.

Patch coming

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SHINDIG-1337) MutableContent throws NPE on getContentBytes() after documentChanged()

Posted by "Mat Mannion (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mat Mannion resolved SHINDIG-1337.
----------------------------------

    Resolution: Fixed

Fixed as per aforementioned code review. Seems quite similar to the patch I submitted weeks ago ;)

> MutableContent throws NPE on getContentBytes() after documentChanged()
> ----------------------------------------------------------------------
>
>                 Key: SHINDIG-1337
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1337
>             Project: Shindig
>          Issue Type: Bug
>          Components: Java
>    Affects Versions: 2.0.0-RC1
>            Reporter: Mat Mannion
>         Attachments: shindig-1337.diff
>
>
> There is an error in MutableContent.getRawContentBytes() that is stopping MutableContent.getContentBytes() being used when the document has been changed, since the result of HTML serialization is not assigned back to the contentBytes property.
> Patch coming

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SHINDIG-1337) MutableContent throws NPE on getContentBytes() after documentChanged()

Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-1337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12877802#action_12877802 ] 

Paul Lindner commented on SHINDIG-1337:
---------------------------------------

thanks Mat, sorry that this one fell through the cracks.

> MutableContent throws NPE on getContentBytes() after documentChanged()
> ----------------------------------------------------------------------
>
>                 Key: SHINDIG-1337
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1337
>             Project: Shindig
>          Issue Type: Bug
>          Components: Java
>    Affects Versions: 2.0.0-RC1
>            Reporter: Mat Mannion
>         Attachments: shindig-1337.diff
>
>
> There is an error in MutableContent.getRawContentBytes() that is stopping MutableContent.getContentBytes() being used when the document has been changed, since the result of HTML serialization is not assigned back to the contentBytes property.
> Patch coming

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SHINDIG-1337) MutableContent throws NPE on getContentBytes() after documentChanged()

Posted by "Gagandeep Singh (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-1337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12877733#action_12877733 ] 

Gagandeep Singh commented on SHINDIG-1337:
------------------------------------------

Hi Matt

http://codereview.appspot.com/1606041/show solves the same problem as what you were facing.


> MutableContent throws NPE on getContentBytes() after documentChanged()
> ----------------------------------------------------------------------
>
>                 Key: SHINDIG-1337
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1337
>             Project: Shindig
>          Issue Type: Bug
>          Components: Java
>    Affects Versions: 2.0.0-RC1
>            Reporter: Mat Mannion
>         Attachments: shindig-1337.diff
>
>
> There is an error in MutableContent.getRawContentBytes() that is stopping MutableContent.getContentBytes() being used when the document has been changed, since the result of HTML serialization is not assigned back to the contentBytes property.
> Patch coming

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SHINDIG-1337) MutableContent throws NPE on getContentBytes() after documentChanged()

Posted by "Mat Mannion (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mat Mannion updated SHINDIG-1337:
---------------------------------

    Attachment: shindig-1337.diff

Patch assigns result of serialisation back to member var.

> MutableContent throws NPE on getContentBytes() after documentChanged()
> ----------------------------------------------------------------------
>
>                 Key: SHINDIG-1337
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1337
>             Project: Shindig
>          Issue Type: Bug
>          Components: Java
>    Affects Versions: 2.0.0-RC1
>            Reporter: Mat Mannion
>         Attachments: shindig-1337.diff
>
>
> There is an error in MutableContent.getRawContentBytes() that is stopping MutableContent.getContentBytes() being used when the document has been changed, since the result of HTML serialization is not assigned back to the contentBytes property.
> Patch coming

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.