You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by ham1 <gi...@git.apache.org> on 2017/12/23 18:47:11 UTC
[GitHub] jmeter pull request #368: Csv sample reader fix
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/368
Csv sample reader fix
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ham1/jmeter CsvSampleReader_fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jmeter/pull/368.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #368
----
commit f4e310901f8e108736ae0b27cfaebbc987761549
Author: Graham Russell <gr...@...>
Date: 2017-12-23T18:09:37Z
Added extra test and fixed failure
commit 083b1ae4ccbc9382ee09b77d69a4fb50b70ea2c0
Author: Graham Russell <gr...@...>
Date: 2017-12-23T18:37:43Z
Formatting and tidy
----
---
[GitHub] jmeter issue #368: Csv sample reader fix
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/jmeter/pull/368
# [Codecov](https://codecov.io/gh/apache/jmeter/pull/368?src=pr&el=h1) Report
> Merging [#368](https://codecov.io/gh/apache/jmeter/pull/368?src=pr&el=desc) into [trunk](https://codecov.io/gh/apache/jmeter/commit/998b3302a10ad8f298c12e67e08369f5a205018d?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `81.25%`.
[](https://codecov.io/gh/apache/jmeter/pull/368?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## trunk #368 +/- ##
============================================
+ Coverage 58.35% 58.36% +0.01%
- Complexity 10288 10290 +2
============================================
Files 1164 1164
Lines 74127 74126 -1
Branches 7298 7298
============================================
+ Hits 43254 43266 +12
+ Misses 28359 28349 -10
+ Partials 2514 2511 -3
```
| [Impacted Files](https://codecov.io/gh/apache/jmeter/pull/368?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/jmeter/report/core/CsvSampleReaderTest.java](https://codecov.io/gh/apache/jmeter/pull/368/diff?src=pr&el=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvcmVwb3J0L2NvcmUvQ3N2U2FtcGxlUmVhZGVyVGVzdC5qYXZh) | `78.18% <100%> (+4.49%)` | `11 <1> (-1)` | :arrow_down: |
| [...org/apache/jmeter/report/core/CsvSampleReader.java](https://codecov.io/gh/apache/jmeter/pull/368/diff?src=pr&el=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvcmVwb3J0L2NvcmUvQ3N2U2FtcGxlUmVhZGVyLmphdmE=) | `57.57% <50%> (+0.65%)` | `12 <0> (ø)` | :arrow_down: |
| [src/core/org/apache/jmeter/report/core/Sample.java](https://codecov.io/gh/apache/jmeter/pull/368/diff?src=pr&el=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvcmVwb3J0L2NvcmUvU2FtcGxlLmphdmE=) | `41.02% <0%> (+2.56%)` | `11% <0%> (+1%)` | :arrow_up: |
| [...mpler/hc/JMeterPoolingClientConnectionManager.java](https://codecov.io/gh/apache/jmeter/pull/368/diff?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL2h0dHAvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC9zYW1wbGVyL2hjL0pNZXRlclBvb2xpbmdDbGllbnRDb25uZWN0aW9uTWFuYWdlci5qYXZh) | `30.95% <0%> (+3.17%)` | `11% <0%> (+1%)` | :arrow_up: |
| [...re/org/apache/jmeter/engine/DistributedRunner.java](https://codecov.io/gh/apache/jmeter/pull/368/diff?src=pr&el=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvZW5naW5lL0Rpc3RyaWJ1dGVkUnVubmVyLmphdmE=) | `85.95% <0%> (+4.13%)` | `32% <0%> (+1%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/jmeter/pull/368?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/jmeter/pull/368?src=pr&el=footer). Last update [998b330...083b1ae](https://codecov.io/gh/apache/jmeter/pull/368?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
[GitHub] jmeter pull request #368: Csv sample reader fix
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/jmeter/pull/368
---