You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/09/27 03:09:32 UTC
[GitHub] [incubator-seatunnel] liugddx opened a new pull request, #2907: fix some error when docker version is old
liugddx opened a new pull request, #2907:
URL: https://github.com/apache/incubator-seatunnel/pull/2907
close #2905
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
run `JdbcMysqlIT` and `JdbcPostgresIT` ,some error will happen,and the resion is docker version is old.
refer to
https://stackoverflow.com/questions/69706677/cannot-start-postgresql-docker-container-docker-entrypoint-initdb-d-oper
https://hub.docker.com/layers/bitnami/mysql/8.0.29/images/sha256-15b89acd8f2971ea127934a186e6d2483b97ffe325619d8b1bc747b303636f57?context=explore
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on pull request #2907: [hotfix][e2e][jdbc] fix some error when docker version is old
Posted by GitBox <gi...@apache.org>.
liugddx commented on PR #2907:
URL: https://github.com/apache/incubator-seatunnel/pull/2907#issuecomment-1260321002
PTAL thanks . @CalvinKirs @EricJoy2048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on pull request #2907: [hotfix][e2e][jdbc] fix some error when docker version is old
Posted by GitBox <gi...@apache.org>.
liugddx commented on PR #2907:
URL: https://github.com/apache/incubator-seatunnel/pull/2907#issuecomment-1259342908
please rerun CI. @EricJoy2048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on pull request #2907: [hotfix][e2e][jdbc] fix some error when docker version is old
Posted by GitBox <gi...@apache.org>.
liugddx commented on PR #2907:
URL: https://github.com/apache/incubator-seatunnel/pull/2907#issuecomment-1259078221
> you'll need to update Docker, runc, and likely libseccomp on your host. But this PR does have some optimizations and I think this change ok.
Yeah,i found some problems when running `JdbcMysqlIT`,i will fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ashulin commented on a diff in pull request #2907: [hotfix][e2e][jdbc] fix some error when docker version is old
Posted by GitBox <gi...@apache.org>.
ashulin commented on code in PR #2907:
URL: https://github.com/apache/incubator-seatunnel/pull/2907#discussion_r982094919
##########
seatunnel-translation/seatunnel-translation-base/src/main/java/org/apache/seatunnel/translation/source/ParallelSource.java:
##########
@@ -101,13 +101,13 @@ public ParallelSource(SeaTunnelSource<T, SplitT, StateT> source,
@Override
public void open() throws Exception {
+ parallelEnumeratorContext.register();
executorService = ThreadPoolExecutorFactory.createScheduledThreadPoolExecutor(1, String.format("parallel-split-enumerator-executor-%s", subtaskId));
splitEnumerator.open();
if (restoredSplitState.size() > 0) {
splitEnumerator.addSplitsBack(restoredSplitState, subtaskId);
}
reader.open();
- parallelEnumeratorContext.register();
Review Comment:
why change it?
I have the same question.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #2907: [hotfix][e2e][jdbc] fix some error when docker version is old
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on PR #2907:
URL: https://github.com/apache/incubator-seatunnel/pull/2907#issuecomment-1259031325
I see some error log ` JdbcPostgresIT.testJdbcPostgresSourceAndSinkXA:151 SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ashulin merged pull request #2907: [hotfix][e2e][jdbc] fix some error when docker version is old
Posted by GitBox <gi...@apache.org>.
ashulin merged PR #2907:
URL: https://github.com/apache/incubator-seatunnel/pull/2907
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #2907: [hotfix][e2e][jdbc] fix some error when docker version is old
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on PR #2907:
URL: https://github.com/apache/incubator-seatunnel/pull/2907#issuecomment-1259056046
you'll need to update Docker, runc, and likely libseccomp on your host.
But this PR does have some optimizations and I think this change ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 commented on a diff in pull request #2907: [hotfix][e2e][jdbc] fix some error when docker version is old
Posted by GitBox <gi...@apache.org>.
hailin0 commented on code in PR #2907:
URL: https://github.com/apache/incubator-seatunnel/pull/2907#discussion_r981909674
##########
seatunnel-translation/seatunnel-translation-base/src/main/java/org/apache/seatunnel/translation/source/ParallelSource.java:
##########
@@ -101,13 +101,13 @@ public ParallelSource(SeaTunnelSource<T, SplitT, StateT> source,
@Override
public void open() throws Exception {
+ parallelEnumeratorContext.register();
executorService = ThreadPoolExecutorFactory.createScheduledThreadPoolExecutor(1, String.format("parallel-split-enumerator-executor-%s", subtaskId));
splitEnumerator.open();
if (restoredSplitState.size() > 0) {
splitEnumerator.addSplitsBack(restoredSplitState, subtaskId);
}
reader.open();
- parallelEnumeratorContext.register();
Review Comment:
why remove it?
@ashulin please help to review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on pull request #2907: [hotfix][e2e][jdbc] fix some error when docker version is old
Posted by GitBox <gi...@apache.org>.
liugddx commented on PR #2907:
URL: https://github.com/apache/incubator-seatunnel/pull/2907#issuecomment-1269571216
@EricJoy2048 help to review. I'm using a old version docker environment.Now a little pretty vexed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 commented on a diff in pull request #2907: [hotfix][e2e][jdbc] fix some error when docker version is old
Posted by GitBox <gi...@apache.org>.
hailin0 commented on code in PR #2907:
URL: https://github.com/apache/incubator-seatunnel/pull/2907#discussion_r981911992
##########
seatunnel-translation/seatunnel-translation-base/src/main/java/org/apache/seatunnel/translation/source/ParallelSource.java:
##########
@@ -101,13 +101,13 @@ public ParallelSource(SeaTunnelSource<T, SplitT, StateT> source,
@Override
public void open() throws Exception {
+ parallelEnumeratorContext.register();
executorService = ThreadPoolExecutorFactory.createScheduledThreadPoolExecutor(1, String.format("parallel-split-enumerator-executor-%s", subtaskId));
splitEnumerator.open();
if (restoredSplitState.size() > 0) {
splitEnumerator.addSplitsBack(restoredSplitState, subtaskId);
}
reader.open();
- parallelEnumeratorContext.register();
Review Comment:
you should revert？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on pull request #2907: [hotfix][e2e][jdbc] fix some error when docker version is old
Posted by GitBox <gi...@apache.org>.
liugddx commented on PR #2907:
URL: https://github.com/apache/incubator-seatunnel/pull/2907#issuecomment-1263211190
PTAL. @TyrantLucifer @CalvinKirs .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org