You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@s2graph.apache.org by "Daewon Jeong (JIRA)" <ji...@apache.org> on 2016/11/10 02:28:58 UTC

[jira] [Created] (S2GRAPH-127) Refactor ExceptionHander Object into Class.

Daewon Jeong created S2GRAPH-127:
------------------------------------

             Summary: Refactor ExceptionHander Object into Class.
                 Key: S2GRAPH-127
                 URL: https://issues.apache.org/jira/browse/S2GRAPH-127
             Project: S2Graph
          Issue Type: Improvement
            Reporter: Daewon Jeong
            Priority: Minor


Improvement

We are using one single global object ExceptionHandler to handle both of following fail scenario.

# To publish all incoming requests({{WALLOG}}) into kafka topic.
# To publish failed mutations when {{Storage}} failed to mutate into backend storage.


{{WALLOG}} should be handled on REST server layer, not in {{s2core}}.
{{FAILLOG}} on storage backend should be handled in {{s2core}}.

Let's separate two case by changing ExceptionHandler from object to class so each case can use separate class instance for each usage.

Basically, any failure on s2core should throw exception so client can decide how to process exception, but this can be large issue so let's make it separate issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)