[GitHub] gatorsmile commented on a change in pull request #23507: [SPARK-26576][SQL] Broadcast hint not applied to partitioned table

[GitBox <gi...@apache.org>]

gatorsmile commented on a change in pull request #23507: [SPARK-26576][SQL] Broadcast hint not applied to partitioned table
URL: https://github.com/apache/spark/pull/23507#discussion_r246987153
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PruneFileSourcePartitions.scala
 ##########
 @@ -71,7 +71,13 @@ private[sql] object PruneFileSourcePartitions extends Rule[LogicalPlan] {
         // Keep partition-pruning predicates so that they are visible in physical planning
         val filterExpression = filters.reduceLeft(And)
         val filter = Filter(filterExpression, prunedLogicalRelation)
-        Project(projects, filter)
+        op match {
+          case h: ResolvedHint =>
 
 Review comment:
   The bug is not here. We should get rid of this lines:
   https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala#L71-L72
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org