You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Laszlo Puskas <lp...@hortonworks.com> on 2017/07/03 09:53:53 UTC
Re: Review Request 60540: AMBARI-21339 logviewer started along with
nimbus if supervisor is not running on the same machine
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60540/
-----------------------------------------------------------
(Updated July 3, 2017, 9:53 a.m.)
Review request for Ambari, Attila Doroszlai, Sumit Mohanty, and Sebastian Toader.
Changes
-------
Fixed unit tests.
Bugs: AMBARI-21339
https://issues.apache.org/jira/browse/AMBARI-21339
Repository: ambari
Description
-------
Logviewer is only started along with the supervisor so inn cases when nimbus runs on a node not hosting supervisor logviever doesn't run.
Solution:
- in such cases the logviewr is started along with nimbus
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/nimbus.py a6bc437
ambari-server/src/test/python/stacks/2.1/STORM/test_storm_nimbus.py 35f057c
ambari-server/src/test/python/stacks/2.1/configs/default-storm-start.json 27cb63e
ambari-server/src/test/python/stacks/2.1/configs/default.json e04e1eb
ambari-server/src/test/python/stacks/2.1/configs/secured-storm-start.json 1b027b7
ambari-server/src/test/python/stacks/2.1/configs/secured.json 61b359c
Diff: https://reviews.apache.org/r/60540/diff/2/
Changes: https://reviews.apache.org/r/60540/diff/1-2/
Testing
-------
Manually on dev env.
- provision cluster with storm, nimbus and supervisor running on the same host -> logviewer started along with *supervisor*
- provision cluster with storm, nimbus running "alone" on the node -> logviewer started along with *nimbus*
Thanks,
Laszlo Puskas
Re: Review Request 60540: AMBARI-21339 logviewer started along with
nimbus if supervisor is not running on the same machine
Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60540/#review179497
-----------------------------------------------------------
Ship it!
Ship It!
- Sebastian Toader
On July 3, 2017, 11:53 a.m., Laszlo Puskas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60540/
> -----------------------------------------------------------
>
> (Updated July 3, 2017, 11:53 a.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Sumit Mohanty, and Sebastian Toader.
>
>
> Bugs: AMBARI-21339
> https://issues.apache.org/jira/browse/AMBARI-21339
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Logviewer is only started along with the supervisor so inn cases when nimbus runs on a node not hosting supervisor logviever doesn't run.
>
> Solution:
> - in such cases the logviewr is started along with nimbus
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/nimbus.py a6bc437
> ambari-server/src/test/python/stacks/2.1/STORM/test_storm_nimbus.py 35f057c
> ambari-server/src/test/python/stacks/2.1/configs/default-storm-start.json 27cb63e
> ambari-server/src/test/python/stacks/2.1/configs/default.json e04e1eb
> ambari-server/src/test/python/stacks/2.1/configs/secured-storm-start.json 1b027b7
> ambari-server/src/test/python/stacks/2.1/configs/secured.json 61b359c
>
>
> Diff: https://reviews.apache.org/r/60540/diff/2/
>
>
> Testing
> -------
>
> Manually on dev env.
>
> - provision cluster with storm, nimbus and supervisor running on the same host -> logviewer started along with *supervisor*
> - provision cluster with storm, nimbus running "alone" on the node -> logviewer started along with *nimbus*
>
>
> Thanks,
>
> Laszlo Puskas
>
>
Re: Review Request 60540: AMBARI-21339 logviewer started along with
nimbus if supervisor is not running on the same machine
Posted by Attila Doroszlai <ad...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60540/#review179493
-----------------------------------------------------------
Ship it!
Ship It!
- Attila Doroszlai
On July 3, 2017, 11:53 a.m., Laszlo Puskas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60540/
> -----------------------------------------------------------
>
> (Updated July 3, 2017, 11:53 a.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Sumit Mohanty, and Sebastian Toader.
>
>
> Bugs: AMBARI-21339
> https://issues.apache.org/jira/browse/AMBARI-21339
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Logviewer is only started along with the supervisor so inn cases when nimbus runs on a node not hosting supervisor logviever doesn't run.
>
> Solution:
> - in such cases the logviewr is started along with nimbus
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/nimbus.py a6bc437
> ambari-server/src/test/python/stacks/2.1/STORM/test_storm_nimbus.py 35f057c
> ambari-server/src/test/python/stacks/2.1/configs/default-storm-start.json 27cb63e
> ambari-server/src/test/python/stacks/2.1/configs/default.json e04e1eb
> ambari-server/src/test/python/stacks/2.1/configs/secured-storm-start.json 1b027b7
> ambari-server/src/test/python/stacks/2.1/configs/secured.json 61b359c
>
>
> Diff: https://reviews.apache.org/r/60540/diff/2/
>
>
> Testing
> -------
>
> Manually on dev env.
>
> - provision cluster with storm, nimbus and supervisor running on the same host -> logviewer started along with *supervisor*
> - provision cluster with storm, nimbus running "alone" on the node -> logviewer started along with *nimbus*
>
>
> Thanks,
>
> Laszlo Puskas
>
>